Fix BC break in TranslatorServiceFactory #5979

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

Martin-P commented Mar 15, 2014

Fix for issue #5978. The check for the intl extension must be done after checking for the translator config key, not before. The test for this was deactivated, this PR also reactivates that test again.

Contributor

roelvanduijnhoven commented Apr 1, 2014

This would also solve issues that I am having. In my configuration the ocale is explicitly set, thus no need to fall back to DummyTranslator.

Contributor

Martin-P commented Apr 1, 2014

Did a rebase on my branch, because the CS-fixer was broken and made Travis fail. All is well now :)

Ocramius added this to the 2.3.1 milestone Apr 3, 2014

Ocramius self-assigned this Apr 3, 2014

@Ocramius Ocramius added a commit that referenced this pull request Apr 3, 2014

@Ocramius Ocramius Merge branch 'hotfix/#5979-#5978-translator-service-factory-without-i…
…ntl' into develop


Close #5979 #5978
Forward Port #5979 #5978
bf42e30

Ocramius closed this in 2ac901c Apr 3, 2014

Martin-P deleted the Martin-P:issue-5978 branch Aug 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment