Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

code-to-explain-code test in MultiCheckboxTest to check multi selected #6070

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

Victory commented Mar 31, 2014

I think it may be a bit confusing on how an $optionValue and $selectedOptions work together with Zend\Form\Element\MultiCheckbox for those who are not using Zend\Form\View\Helper\FormMultiCheckbox I hope this test will explain this issue in code and that people will feel more comfortable creating their own view helpers in the future.

Thank you for you consideration!

Contributor

Victory commented Apr 1, 2014

I am not sure how to restart travis-ci for this example. The build broke because of composer hanging on download, likely some form of network error, not related to code changes.

https://travis-ci.org/zendframework/zf2/jobs/21983070

Contributor

samsonasik commented Apr 1, 2014

maybe you can rebase against master and do git push --force

Contributor

Victory commented Apr 1, 2014

Thank you @samsonasik, right now github seems to be having network errors, once that is fixed i will try the rebase/force. On my own travis-ci test i can manually request a rebuild is that not an option here?

Contributor

samsonasik commented Apr 2, 2014

I think travis is ok now, the failed build is not related with your PR ;)

Contributor

Victory commented Apr 2, 2014

Yeah it seems to keep failing on other things but my PR seemed fine, will this PR even be considered until i can get the green mark from travis?

@Ocramius Ocramius added this to the 2.3.1 milestone Apr 2, 2014

@Ocramius Ocramius self-assigned this Apr 2, 2014

@Ocramius Ocramius closed this in ecc6830 Apr 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment