Validator\Ip should not allow newlines in any case. #6104

Merged
merged 1 commit into from Apr 14, 2014

Conversation

Projects
None yet
3 participants
Contributor

sasezaki commented Apr 8, 2014

<?php
use Zend\Validator\Ip;

var_dump((new Ip)->isValid("127.000.000.001"));  // true (expected)
var_dump((new Ip)->isValid("127.000.000.001\n")); // true (Unexpected)
var_dump((new Ip)->isValid("127.0.0.1\n")); //false (expected)

This issue was caused by ZF-10621
29516d4#diff-1f6ffee384d80d41af718d92b4b7ea76R144

related fix http://framework.zend.com/issues/browse/ZF-8640

Ocramius added this to the 2.3.1 milestone Apr 8, 2014

@weierophinney weierophinney added a commit that referenced this pull request Apr 14, 2014

@weierophinney weierophinney Merge pull request #6104 from sasezaki/validator_newslines_regex
Validator\Ip should not allow newlines in any case.
950936a

@weierophinney weierophinney added a commit that referenced this pull request Apr 14, 2014

@weierophinney weierophinney Merge branch 'hotfix/6104' into develop
Forward port #6104
1f5b1c9

@weierophinney weierophinney merged commit 6d4c84d into zendframework:master Apr 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

weierophinney self-assigned this Apr 14, 2014

@weierophinney weierophinney added a commit that referenced this pull request Apr 14, 2014

@weierophinney weierophinney Merge branch 'hotfix/6104'
Close #6104
f4552c5

sasezaki deleted the sasezaki:validator_newslines_regex branch Apr 17, 2014

@weierophinney weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#6104 from sasezaki/val…
…idator_newslines_regex

Validator\Ip should not allow newlines in any case.
ec3566b

@weierophinney weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/6104' 1e149f3

@weierophinney weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/6104' into develop 8936878
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment