Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Db\Sql delete parameters dependency #6262

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

turrsis commented May 13, 2014

Remove $driver from IF which switch between getSqlString() and prepareStatement() algorithm
Because $parameterContainer is depends of $driver in many methods.
As result - methods is more consistently.

@Ocramius Ocramius added the Db label May 13, 2014

Member

Ocramius commented May 13, 2014

@turrsis this change requires new test coverage for the introduced conditionals.

Contributor

turrsis commented May 13, 2014

@Ocramius This PR is only reduce algorithmic complexity. All changes in protected functions, and algorithm is not changed. To my mind this cover by existing tests.

Member

Ocramius commented May 13, 2014

@turrsis thanks for clarifying: makes sense.

delete parameters dependency
remove $driver from IF which switch between getSqlString() and prepareStatement() algorithm
Contributor

samsonasik commented May 24, 2014

@Ocramius I think the label "awaiting author updates" should be unselected to easiest priority for merge...

Member

Ocramius commented May 24, 2014

@samsonasik thanks for noticing it - removed!

Contributor

turrsis commented May 26, 2014

@Ocramius you were right - this change requires change tests

Contributor

turrsis commented May 27, 2014

Close because already included in zendframework#5701

@turrsis turrsis closed this May 27, 2014

@Ocramius Ocramius added the duplicate label May 27, 2014

@turrsis turrsis deleted the turrsis:hotfix/db-sql-cleaning2 branch May 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment