New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6414-Add a condition for captcha element #7030

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jbenoit2011
Contributor

jbenoit2011 commented Dec 13, 2014

I added a condition when the element is a Captcha. This way, no more validator errors. Just reCaptcha trigger an error validation about the usage of frameborder attribute in iframe tag, but it is reCaptcha related. Not zf2 responsibility.

I didn't write any tests, given the fact it is related to html validation. But I run the usual tests, and nothing goes wrong.

I hope I didn't messed up everything, since it is my first PR.

Tell me if something wrong.

Thanks.
Julien.

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Dec 13, 2014

Member

I didn't write any tests, given the fact it is related to html validation. But I run the usual tests, and nothing goes wrong.

Requires a new test anyway: nothing gets merged without tests :-\

Member

Ocramius commented Dec 13, 2014

I didn't write any tests, given the fact it is related to html validation. But I run the usual tests, and nothing goes wrong.

Requires a new test anyway: nothing gets merged without tests :-\

@jbenoit2011

This comment has been minimized.

Show comment
Hide comment
@jbenoit2011

jbenoit2011 Dec 13, 2014

Contributor

Well, the test failed on Travis while it was good on my computer. I'm goin' to check that.

Contributor

jbenoit2011 commented Dec 13, 2014

Well, the test failed on Travis while it was good on my computer. I'm goin' to check that.

@jbenoit2011

This comment has been minimized.

Show comment
Hide comment
@jbenoit2011

jbenoit2011 Dec 14, 2014

Contributor

The test passed on PHP 5.4/5.5/5.6.
Not executed on PHP 5.3 because of an error in AbstractHelperTest:

PHP Parse error:  syntax error, unexpected T_OBJECT_OPERATOR in /home/travis/build/zendframework/zf2/tests/ZendTest/Form/View/Helper/AbstractHelperTest.php on line 41

And partially executed on HHVM because of "Nesting level too deep".
But I think these errors are not related to my commits.

Contributor

jbenoit2011 commented Dec 14, 2014

The test passed on PHP 5.4/5.5/5.6.
Not executed on PHP 5.3 because of an error in AbstractHelperTest:

PHP Parse error:  syntax error, unexpected T_OBJECT_OPERATOR in /home/travis/build/zendframework/zf2/tests/ZendTest/Form/View/Helper/AbstractHelperTest.php on line 41

And partially executed on HHVM because of "Nesting level too deep".
But I think these errors are not related to my commits.

@Ocramius Ocramius self-assigned this Dec 14, 2014

@Ocramius Ocramius added this to the 2.3.4 milestone Dec 14, 2014

Ocramius added a commit that referenced this pull request Dec 16, 2014

Ocramius added a commit that referenced this pull request Dec 16, 2014

Ocramius added a commit that referenced this pull request Dec 16, 2014

Ocramius added a commit that referenced this pull request Dec 16, 2014

@Ocramius Ocramius closed this in 2b4f614 Dec 16, 2014

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Dec 16, 2014

Member

@jbenoit2011 merged, thanks!

master: 2b4f614
develop: 3330af3

Member

Ocramius commented Dec 16, 2014

@jbenoit2011 merged, thanks!

master: 2b4f614
develop: 3330af3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment