Skip to content
This repository has been archived by the owner. It is now read-only.

Updated dependencies to ^2.5 #7665

Merged

Conversation

@weierophinney
Copy link
Member

@weierophinney weierophinney commented Jan 27, 2016

Previously, we were using ~2.5.0, which is equivalent to >=2.5.0,<2.6.0. This is problematic, as a number of components are at 2.6 and 2.7 versions, and some of those newer versions include security fixes. By being too restrictive in the constraints, we are locking users to insecure versions, which is problematic.

As none of these new minor versions introduces backwards compatibility breaks, this patch updates to use the ^2.5 constraint to allow >=2.5.0,<3.0.0 versions to be installed for all components.

The plan is to do an immediate 2.5.3 release with these changes.

Previously, we were using `~2.5.0`, which is equivalent to `>=2.5.0,<2.6.0`.
This is problematic, as a number of components are at 2.6 and 2.7 versions, and
some of those newer versions include security fixes. By being too restrictive in
the constraints, we are locking users to insecure versions, which is problematic.

As none of these new minor versions introduces backwards compatibility breaks,
this patch updates to use the `^2.5` constraint to allow `>=2.5.0,<3.0.0`
versions to be installed for all components.
@weierophinney weierophinney added this to the 2.5.3 milestone Jan 27, 2016
weierophinney added a commit that referenced this issue Jan 27, 2016
@weierophinney weierophinney merged commit c2300cc into zendframework:master Jan 27, 2016
weierophinney added a commit that referenced this issue Jan 27, 2016
@weierophinney weierophinney deleted the feature/looser-constraints branch Jan 27, 2016
noopable
Copy link
Contributor

noopable commented on c2300cc Mar 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As none of these new minor versions introduces backwards compatibility breaks

For example, zend-mvc breaks BC at 2.7.x.
Zend\Mvc\View\Http\ViewManager losts some methods.
ServiceLocatorAwareInterface was removed from the other classes.
Thus, old services raise E_USER_NOTICE.

Loading

@JulienBreux
Copy link

@JulienBreux JulienBreux commented May 19, 2016

@noopable Thx for this infos!

Loading

@weierophinney
Copy link
Member Author

@weierophinney weierophinney commented May 19, 2016

@noopable Can you please provide an issue report against zend-mvc detailing the specific errors you're seeing?

The removal of ServiceLocatorAwareInterface implementation only occurred for controllers, and we modified the initializer that injects service locator aware controllers to also duck-type against the setServiceLocator() method, which ensures no breakage. If you're referring to the deprecation notice that occurs from using the composed service locator in controllers, this deprecation notice is intentional, to signal you to change your code to make it future-proof. Similarly, for general services that are ServiceLocatorAware, we raise a deprecation notice in the initializer that injects the service locator; again, this is intentional. For more information, please see my blog post on deprecating ServiceLocatorAware.

Finally, the ViewManager is intended as an internal detail for wiring listeners and services related to views, and wasn't really expected to be an extension point, so I'm curious to see what you may have been using!

If you're seeing any other errors, please report them against zend-mvc so we can evaluate them. Thanks!

Loading

@noopable
Copy link
Contributor

@noopable noopable commented May 20, 2016

@weierophinney
Thank you for your blog post.
I think so too.

My issue was duplicate with this. It was already resolved.
zendframework/zend-mvc#86
I thought that removing Di settings for V3 was not bug at that time. My posts was in just after..

Another,my private CMS changes the theme after routing.It sometimes needs to change the layout script or the view paths . My codes use ViewManager::getLayout() , ViewManager::getResolver() .
I was trembling, but it is ok now, I can change my codes for these.

Loading

@welington-m
Copy link

@welington-m welington-m commented Jan 4, 2017

Thanks

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants