Zf2-207, ZF2-212 #917

Merged
merged 2 commits into from Mar 12, 2012

3 participants

@umpirsky

Fixed issues:

We were totally missing Cldr behavior without cache. So I added tests.

The only strange thing is that now ZendTest\Locale\Data\CldrTest::testLanguage fails, Cldr::getDisplayLanguage('de) returns languages in English. it would be nice if someone can take a look at it.

@robertbasic

Could it be possible to break up this in 2 separate pull requests? It's difficult to see what fixes what issue.

Thanks!

@umpirsky
@marc-mabe marc-mabe commented on the diff Mar 11, 2012
tests/Zend/Locale/Data/CldrCachedTest.php
+ 'adapter' => array(
+ 'name' => 'Filesystem',
+ 'options' => array(
+ 'ttl' => 1,
+ 'cache_dir' => $this->_cacheDir,
+ )
+ ),
+ 'plugins' => array(
+ array(
+ 'name' => 'serializer',
+ 'options' => array(
+ 'serializer' => 'php_serialize',
+ ),
+ ),
+ ),
+ ));
@marc-mabe
Zend Framework member
marc-mabe added a line comment Mar 11, 2012

I'd prefer to use the memory adapter on testing cache consumers to simplify things ;)

@umpirsky
umpirsky added a line comment Mar 11, 2012

I agree, but I just moved this code from CldrTest to CldrCachedTest. You can fix that in new PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@weierophinney weierophinney merged commit 0d350bb into zendframework:master Mar 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment