Various testsuite fixes #990

Closed
wants to merge 4 commits into from

3 participants

@Freeaqingme
Zend Framework member

While fixing some functoinality I fixed these tests in the process.

Since I originally messed up some commits, this pull request is a follow up of pr-#989, so it's probably better to look at this after pr-#989 has been approved.

Benjamin Sch... and others added some commits Feb 13, 2012
@weierophinney
Zend Framework member

Unfortunately, tests still don't run for some of the classes referenced -- Wildfire, DbTable session save handler, and PHPUnit DBUnit support still fail. On the fence about merging this; while they're improvements, they don't fix anything tangible yet. :-(

@Freeaqingme
Zend Framework member

@weierophinney While running the entire test suite I got some fatal errors which stopped execution of php. These tests resolve that (for the components covered). They do /not/ make every single test pass, but that never was the intention.

@weierophinney
Zend Framework member

I was still getting fatal errors for the specific things covered by these changes.

@marc-mabe
Zend Framework member

paddy also did some test cleanups: https://github.com/padraic/zf2/tree/tests/cleanup

@weierophinney
Zend Framework member

These are still failing for me. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment