Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

'Undefined variable: log' in [...]/library/Zend/Application/Resource/Translate.php on line 93 #301

Closed
Pittiplatsch opened this Issue · 5 comments

4 participants

@Pittiplatsch

Only commit e6fb027 is now included in https://github.com/zendframework/zf1/blame/master/library/Zend/Application/Resource/Translate.php#L93, while the already existing fix for THIS issue e7c124c was obviously ignored / reverted again.

@croensch

I've seen it too. It's a problem if you provide 'log' as an instance, from the Bootstrap for example.

I don't know why @froschdesign did not fully "merge" the pull request. Was there something wrong with it? I'm not used to git...

@froschdesign
Collaborator

Mmmh, it was the GitHub "merge" function.

@froschdesign froschdesign added the bug label
@froschdesign froschdesign self-assigned this
@croensch

Strange. AFAIR i created the PR a day after i made the commits, so nothing should be missing.
Well, please just merge the shorter code of e7c124c for the next release.

@akrabat
Collaborator

@froschdesign Are you able to progress this?

@froschdesign froschdesign added this to the 1.12.6 milestone
@xopherdeep xopherdeep referenced this issue from a commit in xopherdeep/Zend-Framework-v1
@froschdesign froschdesign Fixes #301 - Undefined variable in Zend_Application_Resource_Translate c0027c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.