Zend_Navigation_Page_Mvc requires a getRoute() method that is missing in Zend_Controller_Router_Interface #69

Closed
zfbot opened this Issue Apr 5, 2013 · 4 comments

Comments

Projects
None yet
2 participants

zfbot commented Apr 5, 2013

Jira Information

Original Issue:ZF-12553
Issue Type:Coding Standards Violation
Reporter:Laurent Courtin
Created:03/26/13
Assignee:froschdesign
Components:Zend_Navigation

Description

Zend_Navigation_Page_Mvc requires the front controller's router to have a getRoute() method that is missing in Zend_Controller_Router_Interface

This can break an application using custom routers (such as CLI or cross application ones)

zfbot commented Apr 5, 2013

(Originally posted by: froschdesign on 03/26/13)

If we add the {{getRoute()}} method to the interface, then it ends in a BC break.
But we can check the existence of the method in the {{Zend_Navigation_Page_Mvc}} class.

zfbot commented Apr 5, 2013

(Originally posted by: Laurent Courtin on 03/29/13)

According to your comment, I got a working patch for version 1.12.3:

Zend_Navigation_Page_Mvc, line 175, I added the test for method presence:

if ($this->_route && method_exists($front->getRouter(), 'getRoute')) {

zfbot commented Apr 5, 2013

This issue was ported from the ZF2 Jira Issue Tracker at
http://framework.zend.com/issues/browse/ZF-12553

Known GitHub users mentioned in the original message or comment:
@froschdesign

froschdesign was assigned Apr 11, 2013

@froschdesign froschdesign added a commit to froschdesign/zf1 that referenced this issue Aug 23, 2013

@froschdesign froschdesign Fix for #69 - Zend_Navigation_Page_Mvc requires a getRoute() method t…
…hat is missing in Zend_Controller_Router_Interface
742eaaa

@froschdesign froschdesign added a commit that referenced this issue Aug 23, 2013

@froschdesign froschdesign Merge pull request #193 from froschdesign/hotfix/69
Fix for #69 - Zend_Navigation_Page_Mvc requires a getRoute() method
8ff4380
Member

froschdesign commented Aug 23, 2013

Fixed with #193

@xopherdeep xopherdeep pushed a commit to xopherdeep/Zend-Framework-v1 that referenced this issue Jul 3, 2014

@froschdesign froschdesign Fix for #69 - Zend_Navigation_Page_Mvc requires a getRoute() method t…
…hat is missing in Zend_Controller_Router_Interface
2109e19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment