Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Skip infocard tests #222

Closed
wants to merge 2 commits into from

2 participants

@OndraM

CardSpace has been discontinued by Microsoft in 2011:
http://blogs.msdn.com/b/card/archive/2011/02/15/beyond-windows-cardspace.aspx
and SimpleXML implementation has changed somehow in PHP 5.4, making the test failing.

Thus fixing the component implementation would not be worth the effort.

@weierophinney

I'd argue we should remove the component, as the service no longer works anyways; I'll do so when I merge.

@weierophinney weierophinney referenced this pull request from a commit
@weierophinney weierophinney [#222] Remove InfoCard component
- Service no longer exists
b2ebc7e
@froschdesign froschdesign referenced this pull request from a commit
@froschdesign froschdesign Removes the auth adapter for InfoCard
See also #222 - removes the InfoCard component, as the CardSpace service no longer exists
1474ec6
@xopherdeep xopherdeep referenced this pull request from a commit in xopherdeep/Zend-Framework-v1
@weierophinney weierophinney [#222] Remove InfoCard component
- Service no longer exists
0e75b42
@xopherdeep xopherdeep referenced this pull request from a commit in xopherdeep/Zend-Framework-v1
@froschdesign froschdesign Removes the auth adapter for InfoCard
See also #222 - removes the InfoCard component, as the CardSpace service no longer exists
21a09ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 17, 2013
  1. @OndraM

    Proper order of assert params

    OndraM authored
  2. @OndraM

    Mark test skipped as CardSpace has been discontinued by MS in 2011 an…

    OndraM authored
    …d SimpleXML implementation has changed in PHP 5.4
This page is out of date. Refresh to see the latest.
View
18 tests/Zend/InfoCard/AssertionTest.php
@@ -54,6 +54,10 @@ public static function main()
public function setUp()
{
+ if (version_compare(PHP_VERSION, '5.4', '>=')) {
+ $this->markTestSkipped('SimpleXML implementation changed and CardSpace technology is discontinued');
+ }
+
$this->tokenDocument = dirname(__FILE__) . '/_files/signedToken.xml';
$this->sslPubKey = dirname(__FILE__) . '/_files/ssl_pub.cert';
$this->sslPrvKey = dirname(__FILE__) . '/_files/ssl_private.cert';
@@ -72,14 +76,12 @@ public function testAssertionProcess()
$assertions = Zend_InfoCard_Xml_Assertion::getInstance($this->_xmlDocument);
$this->assertTrue($assertions instanceof Zend_InfoCard_Xml_Assertion_Saml);
-
- $this->assertSame($assertions->getMajorVersion(), 1);
- $this->assertSame($assertions->getMinorVersion(), 1);
- $this->assertSame($assertions->getAssertionID(), "uuid:5cf2cd76-acf6-45ef-9059-a811801b80cc");
- $this->assertSame($assertions->getIssuer(), "http://schemas.xmlsoap.org/ws/2005/05/identity/issuer/self");
- $this->assertSame($assertions->getConfirmationMethod(), Zend_InfoCard_Xml_Assertion_Saml::CONFIRMATION_BEARER);
- $this->assertSame($assertions->getIssuedTimestamp(), 1190153823);
-
+ $this->assertSame(1, $assertions->getMajorVersion());
+ $this->assertSame(1, $assertions->getMinorVersion());
+ $this->assertSame("uuid:5cf2cd76-acf6-45ef-9059-a811801b80cc", $assertions->getAssertionID());
+ $this->assertSame("http://schemas.xmlsoap.org/ws/2005/05/identity/issuer/self", $assertions->getIssuer());
+ $this->assertSame(Zend_InfoCard_Xml_Assertion_Saml::CONFIRMATION_BEARER, $assertions->getConfirmationMethod());
+ $this->assertSame(1190153823, $assertions->getIssuedTimestamp());
}
public function testAssertionErrors()
View
7 tests/Zend/InfoCard/CipherTest.php
@@ -39,6 +39,13 @@
class Zend_InfoCard_CipherTest extends PHPUnit_Framework_TestCase
{
+ public function setUp()
+ {
+ if (version_compare(PHP_VERSION, '5.4', '>=')) {
+ $this->markTestSkipped('SimpleXML implementation changed and CardSpace technology is discontinued');
+ }
+ }
+
public function testPkiPadding()
{
if (!extension_loaded('openssl')) {
View
4 tests/Zend/InfoCard/ProcessTest.php
@@ -56,6 +56,10 @@ public static function main()
public function setUp()
{
+ if (version_compare(PHP_VERSION, '5.4', '>=')) {
+ $this->markTestSkipped('SimpleXML implementation changed and CardSpace technology is discontinued');
+ }
+
$this->tokenDocument = dirname(__FILE__) . '/_files/encryptedtoken.xml';
$this->sslPubKey = dirname(__FILE__) . '/_files/ssl_pub.cert';
$this->sslPrvKey = dirname(__FILE__) . '/_files/ssl_private.cert';
View
4 tests/Zend/InfoCard/XmlParsingTest.php
@@ -55,6 +55,10 @@ public static function main()
public function setUp()
{
+ if (version_compare(PHP_VERSION, '5.4', '>=')) {
+ $this->markTestSkipped('SimpleXML implementation changed and CardSpace technology is discontinued');
+ }
+
$this->tokenDocument = dirname(__FILE__) . '/_files/encryptedtoken.xml';
$this->tokenDocument2 = dirname(__FILE__) . '/_files/encryptedtoken2.xml';
$this->loadXmlDocument();
Something went wrong with that request. Please try again.