This repository has been archived by the owner. It is now read-only.

PHP 7.2 support #748

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
7 participants
@Bukashk0zzz
Copy link

Bukashk0zzz commented Jan 7, 2018

Fix issue #747

@froschdesign

This comment has been minimized.

Copy link
Member

froschdesign commented Jan 7, 2018

@Bukashk0zzz
We are sorry, but ZF1 reaches its End of Life (EOL).
We do not accept PR's anymore.

@Slamdunk

This comment has been minimized.

Copy link
Contributor

Slamdunk commented Jan 8, 2018

I run a lot of legacy production apps on ZF1 and I am intended to keep ZF1, if not maintained, at least running on new PHP versions without errors.

May we organize an unofficial but central fork with a specific package name for this, and have it mentioned in the README, @froschdesign ?

@Slamdunk

This comment has been minimized.

Copy link
Contributor

Slamdunk commented Jan 9, 2018

May we organize an unofficial but central fork

I've created a topic on discourse about this: https://discourse.zendframework.com/t/zf1-comminuty-maintained-official-fork/419

@sh4ka

This comment has been minimized.

Copy link

sh4ka commented Feb 7, 2018

Our organization still uses a lot of microservices in zend1, we plan on keep using zend1 for a long time. I do not understand why this forced deprecation. It is unnecessary obsolescence.

@froschdesign

This comment has been minimized.

Copy link
Member

froschdesign commented Feb 7, 2018

@sh4ka

It is unnecessary obsolescence.

Sorry, but it was necessary. Version 2 was released on 5 September 2012. After this date version 1 was supported 4 more years! How many versions should be maintained in parallel?

@@ -289,7 +289,7 @@ protected static function _decodeYaml($currentIndent, &$lines)
{
$config = array();
$inIndent = false;
while (list($n, $line) = each($lines)) {
foreach ($lines as $n => $line) {

This comment has been minimized.

@tavy315

tavy315 Mar 6, 2018

This actually breaks the component, somehow the result is not the same.

This comment has been minimized.

@sh4ka

sh4ka Mar 6, 2018

Would you be so kind to provide an example of this problem? Thank you.

This comment has been minimized.

@jaydiablo

jaydiablo Mar 6, 2018

Yeah, this breaks ZF1 tests, we experienced the same. It's because each moves the array pointer on $lines which is passed by reference, but foreach does not (there's also some pointer movement below with prev).

Correct patch here (we believe, tests passed): diablomedia@ba8cf7a#diff-9235a8f0d83484e2adcf78f7ebffe2caL292

@unhawkable

This comment has been minimized.

Copy link

unhawkable commented May 14, 2018

Please take a look at https://github.com/zf1s - a “composeable” zf1 with some fixes added. All components are available on packagist.org with zf1s/ namespace and we are still keeping php 7.2+ compatibility.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.