Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jan 1, 2013
  1. @samsonasik
Commits on Nov 19, 2012
  1. @weierophinney

    [#2981] test, and apply to route event

    weierophinney authored
    - Added unit tests to ensure response is reset in event for both route
      and dispatch short-circuits
    - Ensured that response is reset after a routing short circuit
Commits on Nov 16, 2012
  1. @devosc

    Controller action HttpResponse is not used by SendResponseListener

    devosc authored
    SendResponseListener is getting the response from the event via the getResponse, whereas the actual HttpResponse returned by the controller action is stored as the result for that event.
        public function indexAction()
            //return new ViewModel();
            $response = new \Zend\Http\PhpEnvironment\Response();
            return $response;
    This is a little confusing given that the AbstractController will stop dispatching when the returned value is a Response instance.
            $result = $this->getEventManager()->trigger(MvcEvent::EVENT_DISPATCH, $e, function($test) {
                return ($test instanceof Response);
    And then the SendResponseLister is pulling from getResponse()
        public function sendResponse(MvcEvent $e)
            $response = $e->getResponse();
            var_dump($response, $e->getResult()); //these instances differ
    It seems like the Mvc\Application should set the result Response as the event response?
            $response = $result->last();
            if ($response instanceof ResponseInterface) {
                $event->setResponse($response); //set response for SendResponseListener
    Or is this an implementation detail rather than a bug?
Commits on Nov 7, 2012
  1. @samsonasik

    fix docblock namespace

    samsonasik authored
Commits on Nov 6, 2012
  1. @samsonasik
Commits on Sep 13, 2012
  1. @x3ak @weierophinney

    ModuleManagerInterface is never used

    x3ak authored weierophinney committed
    Zend\ModuleManager\ModuleManagerInterface is never used
Commits on Aug 24, 2012
  1. @weierophinney

    Remove "application" identifier

    weierophinney authored
    - Removed the "application" identifier from the Zend\Mvc\Application
      EventManager instance. This currently can lead to confusion when you have an
      Application module, as both the identifiers "application" and "Application"
      can be in play; unless you know the difference for the casing, you may not
      know which one to attach to. Additionally, the convention we've established
      within the framework is to only use the FQCN and interface names as
      identifiers; this helps reduce collisions, as well as provide good semantics
      for those attaching listeners. (The one exception is that our controllers, by
      default, also attach the top-level namespace of the extending class, which is
      usually the module namespace; this is a good practice as it makes having
      module-specific listeners trivial.)
Commits on Aug 15, 2012
  1. @weierophinney

    Fix CS issues

    weierophinney authored
    - trailing whitespace
Commits on Aug 11, 2012
  1. @blanchonvincent

    remove unused attribute

    blanchonvincent authored
    remove unused attribute
Commits on Jul 25, 2012
  1. @coss

    Fixed API docblock for the init()

    coss authored
  2. @weierophinney

    Fixed failing navigation tests

    weierophinney authored
    - Removed $defaultServiceConfig from ModuleManagerFactory
    - Modified ModuleManagerFactory to add the ServiceListenerFactory
    - Removed adding the ServiceListenerFactory from Application::init()
    - Updated $defaultServiceConfig in ServiceListenerFactory to reflect
      changes needed for Console
    - Fixed ZendTest\View\Helper\Navigation\AbstractTest to remove adding
      the ServiceListenerFactory (since the ModuleManagerFactory now does
Commits on Jul 24, 2012
  1. @coss

    Added the ability to add custom service listeners in the application …

    coss authored
    - The default service listener can be overridden by using the ServiceListenerInterface key
Commits on Jul 16, 2012
  1. @EvanDotPro
Commits on Jul 9, 2012
  1. @weierophinney

    [zen-49] Correct import statements across framework

    weierophinney authored
    - Ran a script that would create multiple import statements out of multi-line
      import statements, and which would sort all import statements in alphabetic
      order. Script is at and was run by dropping
      into the library/Zend folder and typing (in zsh)
      "for file in **/*.php;do php /path/to/replace-uses.php $file; done"
  2. @Maks3w

    [CS][Library] Set File Header

    Maks3w authored
    The following script replaces the content between PHP open tag and namespace declaration.
    for COMPONENT in $(ls -d *)
        for FILE in $(find $COMPONENT -name "*.php")
            BLOCK="\/\*\*\n \* Zend Framework \(http:\/\/framework\.zend\.com\/\)\n \*\n \* \@link      http:\/\/github\.com\/zendframework\/zf2 for the canonical source repository\n \* \@copyright Copyright \(c\) 2005-2012 Zend Technologies USA Inc\. \(http:\/\/www\.zend\.com\)\n \* \@license   http:\/\/framework\.zend\.com\/license\/new-bsd New BSD License\n \* \@package   Zend_$COMPONENT\n \*\/"
            perl -0777 -i -pe "s/(<\?php(\s*.*)*\nn)/<?php\n$BLOCK\n\nn/" $FILE
  3. @Maks3w

    [CS][library] Remove @copyright & @license

    Maks3w authored
    for fl in $(find . -name "*.php"); do mv $fl $fl.old;       sed '/@copyright/d' $fl.old > $fl;       rm -f $fl.old; done;
    for fl in $(find . -name "*.php"); do mv $fl $fl.old;       sed '/@license/d' $fl.old > $fl;       rm -f $fl.old; done;
Commits on Jul 4, 2012
  1. @EvanDotPro
  2. @EvanDotPro

    Pass service_manager config key to main SM config

    EvanDotPro authored
    This allows for overridding the few "core" services that are configured
    by default by the MVC stack for those who really need to override them.
Commits on Jul 3, 2012
  1. @EvanDotPro

    Add static init() to Zend\Mvc\Application

    EvanDotPro authored
    Also no need to md5() the service manager keys in ServiceListener.
Commits on Jun 30, 2012
  1. @Slamdunk
Commits on Jun 28, 2012
  1. @akrabat
Commits on Jun 25, 2012
  1. @prolic

    Fix CS and phpdoc in Zend\Mvc

    prolic authored
Commits on Jun 7, 2012
  1. @EvanDotPro

    Revert "phpdoc fixes in Zend\Mvc, some cleanup"

    EvanDotPro authored
    This reverts commit dbf4614.
Commits on Jun 6, 2012
  1. @prolic
Commits on May 27, 2012
  1. @blanchonvincent

    fix doc type for EventManagerInterface

    blanchonvincent authored
    fix doc type for EventManagerInterface instead EventCollection
Commits on May 23, 2012
  1. @prolic
Commits on May 17, 2012
  1. @weierophinney

    Updated Zend\Mvc to reference ModuleManager

    weierophinney authored
    - s/(Zend.Module)/\1Manager/
    - s/\/Manager/\/ModuleManager/
Commits on May 15, 2012
  1. @weierophinney

    Zend\Mvc\Application tests

    weierophinney authored
    - Created new set of assertions based on refactored functionality
    - Added and refactored original tests that tested workflow
      - 2 I am unable to get working against expectations due to how the
        scoped application controller works
  2. @weierophinney

    Cleanup in preparation for pull request

    weierophinney authored
    - Added docblocks to as many MVC files as possible
    - Added getServiceLocator() to ServiceLocatorAwareInterface
    - Removed all LocatorAware interfaces in favor of
      - Refactored all classes using LocatorAware interfaces to use SLA
    - Updated ServiceManagerConfiguration to inject EventManagerAware
    - Refactored DispatchListener to remove goto usage
    - Refactored Application to move all event listener attachments into
    - Use "router" as base key for router configuration; simplifies
      RouteFactory, and allows configuring other aspects of router.
    - Small logic cleanups throughout
  3. @weierophinney

    New ViewManager class

    weierophinney authored
    - Created ViewManager class for managing creation and composition of various
      events and objects in the view layer
      - Registers a number of them as services when done
    - Application pulls ViewManager from service manager and attaches it to events
    - ViewManager has an onBootstrap listener that attaches to the bootstrap event
      at high (10000) priority
  4. @weierophinney
  5. @ralphschindler @weierophinney
Commits on May 7, 2012
  1. @weierophinney

    Merge branch 'di-renamed-interfaces' of

    weierophinney authored
    …into feature/zen27-di
  2. @weierophinney

    Merge branch 'patch-2' of into hotfix/m…

    weierophinney authored
  3. @weierophinney

    Merge branch 'stdlib-renamed-interfaces' of…

    weierophinney authored
    …/zf2 into feature/zen27-stdlib
Something went wrong with that request. Please try again.