Skip to content
Commits on Feb 19, 2013
  1. @micheh @ralphschindler
Commits on Feb 1, 2013
  1. @weierophinney

    Ensure run() always returns Application instance

    weierophinney committed
    - Some paths through `Application::run()` would call
      `return $this->completeRequest($event)`; this particular method was returning
      a response object, which meant that `send()` was resulting in a double-render.
      The main `run()` routine typically returns the Application instance, where
      `send()` is a no-op, and thus no double-render can occur.
    - The workaround until this is merged and released is to remove the call to
      `->send()` in your `public/index.php`.
Commits on Jan 25, 2013
  1. @ralphschindler

    Zend\Mvc\Application

    ralphschindler committed
    run() returns the Application object which now has a deprecated
    send() method.  This will ensure IDE's display a deprecated/
    strike-through send() method when Zend\Mvc consumers (The skeleton
    application applications) use send() from their index.php file.
Commits on Jan 21, 2013
  1. @weierophinney

    Removed all @category, @package, and @subpackage annotations

    weierophinney committed
    - Per #2743, and following on #2953 and discussion on the ML
    - Also removes empty docblocks, and empty lines at the end of docblocks
    - Library only; phpdoc is never run on tests anyways, and did not want to
      potentially create breakage due to test expectations that relied on
      annotations. At this time, all tests pass.
Commits on Jan 4, 2013
  1. @weierophinney

    Merge branch 'hotfix/3320' into develop

    weierophinney committed
    Conflicts:
    	library/Zend/File/Transfer/Adapter/AbstractAdapter.php
    	library/Zend/File/Transfer/Adapter/FilterPluginManager.php
    	library/Zend/File/Transfer/Adapter/Http.php
    	library/Zend/File/Transfer/Adapter/ValidatorPluginManager.php
    	library/Zend/File/Transfer/Transfer.php
    	library/Zend/Validator/File/Count.php
    	library/Zend/Validator/File/FilesSize.php
    	tests/ZendTest/File/Transfer/Adapter/AbstractAdapterTestMockAdapter.php
    	tests/ZendTest/File/Transfer/Adapter/AbstractTest.php
    	tests/ZendTest/File/Transfer/Adapter/HttpTest.php
    	tests/ZendTest/File/Transfer/Adapter/HttpTestMockAdapter.php
    	tests/ZendTest/Validator/File/CountTest.php
    	tests/ZendTest/Validator/File/FilesSizeTest.php
Commits on Jan 1, 2013
  1. @samsonasik
Commits on Dec 9, 2012
  1. @prolic

    added phpdoc

    prolic committed
    added default name in SendResponseEvent
    removed unused factories
Commits on Dec 3, 2012
  1. @prolic

    updated send response workflow

    prolic committed
    - implemented changes proposed by weierophinney
    - reverted changes in Console\Response and PhpEnvironment\Response objects
    - added Zend\Mvc\View\SendResponseListener extending the new class
    - added ResponseListenerFactory
    - Response sender triggers events
Commits on Nov 29, 2012
  1. @prolic
Commits on Nov 19, 2012
  1. @weierophinney

    [#2981] test, and apply to route event

    weierophinney committed
    - Added unit tests to ensure response is reset in event for both route
      and dispatch short-circuits
    - Ensured that response is reset after a routing short circuit
Commits on Nov 16, 2012
  1. @devosc

    Controller action HttpResponse is not used by SendResponseListener

    devosc committed
    SendResponseListener is getting the response from the event via the getResponse, whereas the actual HttpResponse returned by the controller action is stored as the result for that event.
    
        public function indexAction()
        {
            //return new ViewModel();
            $response = new \Zend\Http\PhpEnvironment\Response();
            $response->setContent('OK');
    
            return $response;
        }
    
    This is a little confusing given that the AbstractController will stop dispatching when the returned value is a Response instance.
    
            $result = $this->getEventManager()->trigger(MvcEvent::EVENT_DISPATCH, $e, function($test) {
                return ($test instanceof Response);
            });
    
    
    And then the SendResponseLister is pulling from getResponse()
    
        public function sendResponse(MvcEvent $e)
        {
            $response = $e->getResponse();
            var_dump($response, $e->getResult()); //these instances differ
    
    
    
    It seems like the Mvc\Application should set the result Response as the event response?
    
            $response = $result->last();
            if ($response instanceof ResponseInterface) {
                $event->setTarget($this);
                $event->setResponse($response); //set response for SendResponseListener
    
    
    Or is this an implementation detail rather than a bug?
Commits on Nov 7, 2012
  1. @samsonasik

    fix docblock namespace

    samsonasik committed
Commits on Nov 6, 2012
  1. @samsonasik
Commits on Sep 13, 2012
  1. @x3ak @weierophinney

    ModuleManagerInterface is never used

    x3ak committed with weierophinney
    Zend\ModuleManager\ModuleManagerInterface is never used
Commits on Aug 24, 2012
  1. @weierophinney

    Remove "application" identifier

    weierophinney committed
    - Removed the "application" identifier from the Zend\Mvc\Application
      EventManager instance. This currently can lead to confusion when you have an
      Application module, as both the identifiers "application" and "Application"
      can be in play; unless you know the difference for the casing, you may not
      know which one to attach to. Additionally, the convention we've established
      within the framework is to only use the FQCN and interface names as
      identifiers; this helps reduce collisions, as well as provide good semantics
      for those attaching listeners. (The one exception is that our controllers, by
      default, also attach the top-level namespace of the extending class, which is
      usually the module namespace; this is a good practice as it makes having
      module-specific listeners trivial.)
Commits on Aug 15, 2012
  1. @weierophinney

    Fix CS issues

    weierophinney committed
    - trailing whitespace
Commits on Aug 11, 2012
  1. @blanchonvincent

    remove unused attribute

    blanchonvincent committed
    remove unused attribute
Commits on Jul 25, 2012
  1. @coss

    Fixed API docblock for the init()

    coss committed
  2. @weierophinney

    Fixed failing navigation tests

    weierophinney committed
    - Removed $defaultServiceConfig from ModuleManagerFactory
    - Modified ModuleManagerFactory to add the ServiceListenerFactory
    - Removed adding the ServiceListenerFactory from Application::init()
    - Updated $defaultServiceConfig in ServiceListenerFactory to reflect
      changes needed for Console
    - Fixed ZendTest\View\Helper\Navigation\AbstractTest to remove adding
      the ServiceListenerFactory (since the ModuleManagerFactory now does
      that)
Commits on Jul 24, 2012
  1. @coss

    Added the ability to add custom service listeners in the application …

    coss committed
    …config.
    
    - The default service listener can be overridden by using the ServiceListenerInterface key
Commits on Jul 16, 2012
  1. @EvanDotPro
Commits on Jul 9, 2012
  1. @weierophinney

    [zen-49] Correct import statements across framework

    weierophinney committed
    - Ran a script that would create multiple import statements out of multi-line
      import statements, and which would sort all import statements in alphabetic
      order. Script is at https://gist.github.com/3079222 and was run by dropping
      into the library/Zend folder and typing (in zsh)
      "for file in **/*.php;do php /path/to/replace-uses.php $file; done"
  2. @Maks3w

    [CS][Library] Set File Header

    Maks3w committed
    http://framework.zend.com/wiki/display/ZFDEV2/Coding+Standards#CodingStandards-Files
    
    The following script replaces the content between PHP open tag and namespace declaration.
    
    for COMPONENT in $(ls -d *)
    do
        for FILE in $(find $COMPONENT -name "*.php")
        do
            BLOCK="\/\*\*\n \* Zend Framework \(http:\/\/framework\.zend\.com\/\)\n \*\n \* \@link      http:\/\/github\.com\/zendframework\/zf2 for the canonical source repository\n \* \@copyright Copyright \(c\) 2005-2012 Zend Technologies USA Inc\. \(http:\/\/www\.zend\.com\)\n \* \@license   http:\/\/framework\.zend\.com\/license\/new-bsd New BSD License\n \* \@package   Zend_$COMPONENT\n \*\/"
            perl -0777 -i -pe "s/(<\?php(\s*.*)*\nn)/<?php\n$BLOCK\n\nn/" $FILE
        done
    done
  3. @Maks3w

    [CS][library] Remove @copyright & @license

    Maks3w committed
    for fl in $(find . -name "*.php"); do mv $fl $fl.old;       sed '/@copyright/d' $fl.old > $fl;       rm -f $fl.old; done;
    for fl in $(find . -name "*.php"); do mv $fl $fl.old;       sed '/@license/d' $fl.old > $fl;       rm -f $fl.old; done;
Commits on Jul 4, 2012
  1. @EvanDotPro
  2. @EvanDotPro

    Pass service_manager config key to main SM config

    EvanDotPro committed
    This allows for overridding the few "core" services that are configured
    by default by the MVC stack for those who really need to override them.
Commits on Jul 3, 2012
  1. @EvanDotPro

    Add static init() to Zend\Mvc\Application

    EvanDotPro committed
    Also no need to md5() the service manager keys in ServiceListener.
Commits on Jun 30, 2012
  1. @Slamdunk
Commits on Jun 28, 2012
  1. @akrabat
Commits on Jun 25, 2012
  1. @prolic

    Fix CS and phpdoc in Zend\Mvc

    prolic committed
Commits on Jun 7, 2012
  1. @EvanDotPro

    Revert "phpdoc fixes in Zend\Mvc, some cleanup"

    EvanDotPro committed
    This reverts commit dbf4614.
Commits on Jun 6, 2012
  1. @prolic
Commits on May 27, 2012
  1. @blanchonvincent

    fix doc type for EventManagerInterface

    blanchonvincent committed
    fix doc type for EventManagerInterface instead EventCollection
Commits on May 23, 2012
  1. @prolic
Commits on May 17, 2012
  1. @weierophinney

    Updated Zend\Mvc to reference ModuleManager

    weierophinney committed
    - s/(Zend.Module)/\1Manager/
    - s/\/Manager/\/ModuleManager/
Something went wrong with that request. Please try again.