Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Zend\Code\Scanner\FunctionScanner is incomplete #2480

Closed
zfbot opened this Issue · 9 comments

6 participants

@zfbot
Owner

Jira Information

Original Issue: ZF2-301
Issue Type: Improvement
Reporter: adamlundrigan
Created: 05/14/12
Assignee: ralphschindler
Components: Zend\Code\Scanner

Description

Could not forward-port fix for ZF-12155, as function scanning is not yet implemented in ZF2.

@zfbot
Owner

This issue was ported from the ZF2 Jira Issue Tracker at
http://framework.zend.com/issues/browse/ZF2-301

Known GitHub users mentioned in the original message or comment:
@adamlundrigan, @ralphschindler

@ralphschindler
Collaborator

Still an issue?

@ralphschindler
Collaborator

Well, since its empty, I suppose we can remove the class altogether. I think that is what I am inclined to do until a PR comes in for an implementation.

@Srokap

@ralphschindler I'll be probably working on this in near future, but can't promise exactly when. In the meantime, removing it might help to avoid confusion, however there are some places where it's supposed to be used (https://github.com/zendframework/zf2/blob/master/library/Zend/Code/Reflection/FileReflection.php#L199 that should call down to https://github.com/zendframework/zf2/blob/master/library/Zend/Code/Scanner/TokenArrayScanner.php#L253), so raising some warning or throwing NotImplementedException would be better? I'm not familiar yet with approaches you guys use in ZF for such cases.

@samsonasik

any progress on this ?

@Srokap

I have a piece of code that does very simple function parsing using PHP tokenizer, but I don't feel it's good enough to wrap it into PR in comparison to existing code. If there's interest in moving this feature forward, even in not perfect way, I may prepare pull request.

@Ocramius
Collaborator

@Srokap would be preferrable to have MethodScanner either extended or moved into an abstract class, which then has 2 concrete implementations.

@weierophinney

Closing, as nobody appears to be actively moving forward on the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.