Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Add missing @return annotations #3808

Closed
wants to merge 1 commit into from
Closed

Add missing @return annotations #3808

wants to merge 1 commit into from

Conversation

micheh
Copy link
Contributor

@micheh micheh commented Feb 17, 2013

No description provided.

* @param string $permission
* @param \Zend\Permissions\Rbac\AssertionInterface|Callable|null $assert
* @param string $permission
* @param \Zend\Permissions\Rbac\AssertionInterface|Callable|null $assert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in same folder, it should be only AssertionInterface|Callable|null $assert without \Zend\Permissions\Rbac\ prefix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phpDoc of this method misses the $role parameter as well. But both changes should not be part of this PR, as that's not the topic of this PR.

@ghost ghost assigned weierophinney Feb 19, 2013
weierophinney added a commit that referenced this pull request Feb 19, 2013
weierophinney added a commit to zendframework/zend-test that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-test that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-permissions-rbac that referenced this pull request May 15, 2015
weierophinney added a commit to zendframework/zend-permissions-rbac that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants