Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Wincache unexpected return value on internalGetItem #4552

Closed
sebdalink opened this Issue · 1 comment

2 participants

@sebdalink

On internalGetItem function, the expected return value, when item isn't found on cache, is null.
But wincache_ucache_get return false when $key isn't found on cache, so $result has a wrong return value in this case.

@marc-mabe

@sebdalink Thank you for reporting this!
From reading the documentation you are right -> $result needs to be set to null if $success is false.

I'll create a PR but I can't run tests for this adapter - It would be great if you can run the unit tests for this adapter.

@weierophinney weierophinney closed this issue from a commit
@marc-mabe marc-mabe fixed #4552: Zend\Cache\Storage\Adapter\Wincache::getItem() have to r…
…eturn NULL in cases of not found items
304ceb1
@ghost Unknown referenced this issue from a commit
@marc-mabe marc-mabe fixed #4552: Zend\Cache\Storage\Adapter\Wincache::getItem() have to r…
…eturn NULL in cases of not found items
c48ad78
@ghost Unknown referenced this issue from a commit
@weierophinney weierophinney Merge branch 'hotfix/4632'
Close #4632
Fixes #4552
890b320
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.