Revamp Bootstrap #1495

EvanDotPro · 2012-06-13T21:31:29Z

Goals / features of this PR:

Allow for a massively simplified index.php (one liner once autoloading is set up). [done]
Allow modules to override the default services, which previously could only be overridden from application.config.php [done]
Keep track of where all config values came from so we can tell which modules or config files overrode each other. [done]
Fix EventManagerAwareInterface so that it does not force injection of a new event manager if one already exists. [done in #1500]
Allow modules to be able to provide initializers to the ServiceManager. [done in #1695]

index.php after this PR:

<?php
/**
 * This makes our life easier when dealing with paths. Everything is relative
 * to the application root now.
 */
chdir(dirname(__DIR__));

// Setup autoloading
include 'init_autoloader.php';

// Run the application!
Zend\Mvc\Application::init(include 'config/application.config.php')->run()->send();

Please merge ZendSkeletonApplication PR #82 after this.

EvanDotPro · 2012-06-13T21:33:17Z

library/Zend/Mvc/Service/ModuleManagerFactory.php

@@ -58,7 +58,37 @@ public function createService(ServiceLocatorInterface $serviceLocator)
        $configuration    = $serviceLocator->get('ApplicationConfiguration');
        $listenerOptions  = new ListenerOptions($configuration['module_listener_options']);
        $defaultListeners = new DefaultListenerAggregate($listenerOptions);
-        $serviceListener  = new ServiceListener($serviceLocator);
+
+        $serviceConfig    = array(


I know this is not where this should be defined -- it will be defined in a more appropriate location.

Where are you thinking of putting it instead? I'm not 100% against this, tbh, particularly since you can specify an alternate ModuleManager factory in the application config.

prolic · 2012-06-14T14:50:39Z

Fix EventManagerAwareInterface so that it does not force injection of a new event manager if one already exists. - can you provide this bugfix as separated PR, please? So this one can get merged into master already.

EvanDotPro · 2012-06-14T15:29:13Z

@prolic done.. see PR 1500.

This will create some conflicts with this PR though, so I'll have to fix this up.

prolic · 2012-06-14T15:57:00Z

Thanks. For the rest, looks good to me! :-)

marc-mabe · 2012-06-15T06:41:11Z

library/Zend/ModuleManager/ModuleManagerInterface.php

@@ -19,7 +19,7 @@
 * @category Zend
 * @package  Zend_Module
 */
-interface ModuleManagerInterface extends EventManagerAwareInterface, EventsCapableInterface
+interface ModuleManagerInterface extends EventManagerAwareInterface


Don't forget to remove "use Zend\EventManager\EventsCapableInterface;"

Done, thanks.

weierophinney · 2012-06-20T17:38:35Z

I personally am +1 to this, once rebased. ;-) I'm not sure how much discussion we need to make the change -- but it'd be great to get this in for beta5.

prolic · 2012-06-25T20:34:47Z

beta5 is coming... ;-)

…epenency between ModuleManager and Configuration

Also no need to md5() the service manager keys in ServiceListener.

This will enable us to provide useful debugging tools in regards to config merging.

This allows for overridding the few "core" services that are configured by default by the MVC stack for those who really need to override them.

EvanDotPro · 2012-07-04T17:51:16Z

I think this is ready to be reviewed. I'm still not completely happy with where I stuck the default service configuration (in the ModuleManagerFactory as a property), but that's an implementation detail that does not affect the public API. Travisbot should be commenting wit the build status shortly.

travisbot · 2012-07-04T18:03:25Z

This pull request fails (merged a0059e1 into ff7d573).

EvanDotPro · 2012-07-04T18:19:20Z

Fixing Zend\View tests now...

travisbot · 2012-07-04T18:31:01Z

This pull request fails (merged df6d935 into ff7d573).

This is useful for unit testing. Edited Zend\View\Helper\Navigation\AbstractTest to use this.

travisbot · 2012-07-04T20:36:03Z

This pull request fails (merged c914158 into ff7d573).

travisbot · 2012-07-04T22:31:26Z

This pull request passes (merged 51912e1 into ff7d573).

- Removes the loadModules.pre event - Adds a loadModules event - Use constants for event names to match Zend\Mvc - All work contained within listeners now Listeners that need to do things after modules are loaded, but do some work that modules should be able to assume is complete in loadModules.post should attach to the loadModules event with a negative priority.

travisbot · 2012-07-05T10:34:22Z

This pull request passes (merged 99cc61f into ff7d573).

EvanDotPro · 2012-07-05T10:36:15Z

I love you, @travisbot.

EvanDotPro reviewed Jun 13, 2012
View reviewed changes

marc-mabe reviewed Jun 15, 2012
View reviewed changes

SocalNick and others added 11 commits July 3, 2012 14:20

By lazily loading the ServiceManagers we no longer get the circular d…

f0b7287

…epenency between ModuleManager and Configuration

Add static init() to Zend\Mvc\Application

bc17f1b

Also no need to md5() the service manager keys in ServiceListener.

Fix exception message in ServiceListener

24b4260

Add comment explaining doctype config param

f2e435e

Refactor ConfigListener to track value sources

7ec244a

This will enable us to provide useful debugging tools in regards to config merging.

Pass service_manager config key to main SM config

d6d80db

This allows for overridding the few "core" services that are configured by default by the MVC stack for those who really need to override them.

Update ConfigListener tests

c2b0ba8

Update ServiceListener tests

ec2b31c

Allow modules to override service configuration

7ff526d

Update Zend\Application tests

a0059e1

Change 'services' key to 'invokables' in ServiceManagerConfiguration

df6d935

Add extra_config module listener option

c914158

This is useful for unit testing. Edited Zend\View\Helper\Navigation\AbstractTest to use this.

Use extra_config key in Zend\Navigation tests

51912e1

EvanDotPro added 3 commits July 5, 2012 02:42

Update module manage docs for event changes

8774a16

Update ModuleManager tests for event changes

99cc61f

weierophinney merged commit 99cc61f into zendframework:master Jul 5, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revamp Bootstrap #1495

Revamp Bootstrap #1495

EvanDotPro commented Jun 13, 2012

EvanDotPro Jun 13, 2012

weierophinney Jun 20, 2012

prolic commented Jun 14, 2012

EvanDotPro commented Jun 14, 2012

prolic commented Jun 14, 2012

marc-mabe Jun 15, 2012

EvanDotPro Jun 28, 2012

weierophinney commented Jun 20, 2012

prolic commented Jun 25, 2012

EvanDotPro commented Jul 4, 2012

travisbot commented Jul 4, 2012

EvanDotPro commented Jul 4, 2012

travisbot commented Jul 4, 2012

travisbot commented Jul 4, 2012

travisbot commented Jul 4, 2012

travisbot commented Jul 5, 2012

EvanDotPro commented Jul 5, 2012

Revamp Bootstrap #1495

Revamp Bootstrap #1495

Conversation

EvanDotPro commented Jun 13, 2012

Goals / features of this PR:

index.php after this PR:

EvanDotPro Jun 13, 2012

Choose a reason for hiding this comment

weierophinney Jun 20, 2012

Choose a reason for hiding this comment

prolic commented Jun 14, 2012

EvanDotPro commented Jun 14, 2012

prolic commented Jun 14, 2012

marc-mabe Jun 15, 2012

Choose a reason for hiding this comment

EvanDotPro Jun 28, 2012

Choose a reason for hiding this comment

weierophinney commented Jun 20, 2012

prolic commented Jun 25, 2012

EvanDotPro commented Jul 4, 2012

travisbot commented Jul 4, 2012

EvanDotPro commented Jul 4, 2012

travisbot commented Jul 4, 2012

travisbot commented Jul 4, 2012

travisbot commented Jul 4, 2012

travisbot commented Jul 5, 2012

EvanDotPro commented Jul 5, 2012