Skip to content
This repository was archived by the owner on Jan 8, 2020. It is now read-only.

Rename events() to getEventManager() #1669

Merged
weierophinney merged 1 commit into
zendframework:masterfrom
akrabat:hotfix/geteventmanager
Jun 29, 2012
Merged

Rename events() to getEventManager() #1669
weierophinney merged 1 commit into
zendframework:masterfrom
akrabat:hotfix/geteventmanager

Conversation

@akrabat

@akrabat akrabat commented Jun 28, 2012

Copy link
Copy Markdown
Contributor

Also updated rest of code throughout framework.

Obviously, this will affect a lot of code used elsewhere...

@juriansluiman

Copy link
Copy Markdown
Contributor

@akrabat this is to reduce inconsistency with other accessors in the format getSomething()? Along those lines I'd suggest to apply these changes to Zend\Http\Request as well since there are getters Request::uri(), Request::query(), Request::post(), Request::cookies(), Request::file(), Request::server(), Request::env() and Request::headers(). I quickly browsed through some other code and did not stumble upon other places where this type of naming is used, but perhaps there are even more components?

@weierophinney

Copy link
Copy Markdown
Member

@juriansluiman If you want to see that happen, it MUST happen by Tuesday, 3 July 2012. Otherwise, it will have to wait for 3.0. (Also, requires separate PR, obviously).

weierophinney added a commit that referenced this pull request Jun 29, 2012
@weierophinney weierophinney merged commit a8f15a7 into zendframework:master Jun 29, 2012
@juriansluiman

Copy link
Copy Markdown
Contributor

@weierophinney I wrote an email to the ML, to see whether others would agree. If so, I will PR for this change.

weierophinney added a commit to zendframework/zend-modulemanager that referenced this pull request May 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants