This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Use same Shared Event Manager across the board#1971
Closed
Mezzle wants to merge 2 commits into
Closed
Conversation
Make sure that at all points where the SharedEventManager is
being initialised, it is using the same method.
This change makes it so that when calling
```php
$serviceManager->get('SharedEventManager');
```
It will initialise in the same manner as if we were to call
```php
$eventManager->getSharedManager();
```
Without having first set the Shared Manager in the Event Manager
Member
There was a problem hiding this comment.
You must care about the references for this field along the code of the class
Author
There was a problem hiding this comment.
Ah sorry - thought it was extending something :)
Author
|
Not exactly sure why tests are weird on this - going to re-branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that at all points where the SharedEventManager is
being initialised, it is using the same method.
This change makes it so that when calling
It will initialise in the same manner as if we were to call
Without having first set the Shared Manager in the Event Manager