This repository was archived by the owner on Jan 8, 2020. It is now read-only.
Update library/Zend/Di/Definition/ClassDefinition.php#2265
Closed
noopable wants to merge 6 commits into
Closed
Conversation
Member
There was a problem hiding this comment.
Please follow coding standards; all conditionals require braces:
if ($this->class !== $class) {
return array();
}
Member
|
Also, please provide unit tests -- I have no idea what this is supposed to accomplish, and can't be assured it's not breaking other code. |
Contributor
Author
|
thanks. I can't find unit tests about DefinitionList and ClassDefinition. |
Contributor
|
Well: ZendTest\Di\Definition\ClassDefinitionTest - here you go ;) |
Contributor
Author
|
I thought about it . I made a test in DefinitionListTest in this commit And I wrote reproductive code in http://framework.zend.com/issues/browse/ZF2-509?focusedCommentId=51761#comment-51761 Please check it . |
Contributor
Author
|
moved : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http://framework.zend.com/issues/browse/ZF2-509