Skip to content

Zend\Form Added extra unit tests and some code improvements #2361

Closed
wants to merge 1 commit into from

2 participants

@kpieters
  • Fixed FormCollection::shouldWrap function
  • Removed Duplicate code FormElement::render line 173 - 176 === 178 - 181
  • Moved check for name to static getName FormMultiCheckbox::render
  • Improved readability Zend\Form\Form::setValidationGroup
@kpieters kpieters Zend\Form Added extra unit tests and some code improvements
- Fixed FormCollection::shouldWrap function
- Removed Duplicate code FormElement::render line 173 - 176 === 178 - 181
- Moved check for name to static getName FormMultiCheckbox::render
- Improved readability Zend\Form\Form::setValidationGroup
c33da3a
@weierophinney
Zend Framework member

Please rebase this off of the release branch, and re-submit against that branch. A number of items are already fixed in current release and master branches, and, as such, this introduces conflicts.

Thanks!

@weierophinney weierophinney reopened this Sep 14, 2012
@weierophinney
Zend Framework member

Sorry -- right after I wrote that last comment, we renamed the branches. Rebase off of master. :)

I'm going to attempt this now, to see how difficult it is.

@weierophinney weierophinney added a commit that closed this pull request Sep 18, 2012
@weierophinney weierophinney Merge branch 'hotfix/2361'
Close #2361
043ed82
@weierophinney weierophinney added a commit that referenced this pull request Sep 18, 2012
@weierophinney weierophinney Merge branch 'hotfix/2361' into develop
Close #2361
e98c3f4
@weierophinney
Zend Framework member

Merged to master and develop -- thanks!

@kpieters

Nice!

@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney Merge branch 'hotfix/2361'
Close #2361
b6c6635
@ghost Unknown pushed a commit that referenced this pull request Jul 14, 2013
@weierophinney weierophinney Merge branch 'hotfix/2361' into develop
Close #2361
df1942e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.