Skip to content

Loading…

AbstractPluginManager should not respond to... #2648

Closed
wants to merge 1 commit into from

2 participants

@demiankatz

...ServiceManagerAwareInterface; that is a more specific marker not intended for generic plugins.

(This is related to recent discussion on the zf-contributors mailing list).

@demiankatz demiankatz AbstractPluginManager should not respond to ServiceManagerAwareInterf…
…ace; that is a more specific marker not intended for generic plugins.
ef9a512
@weierophinney weierophinney added a commit that referenced this pull request
@weierophinney weierophinney [#2648] Added note to README.md
- Noted the change in README.md
2679e59
@weierophinney weierophinney was assigned
@weierophinney
Zend Framework member

Scheduling for 2.1, and added a note to the changelog to ensure that this can be discovered more easily, as I'm sure we'll have a number of develoeprs who are using this, and whose apps break as a result.

@ghost Unknown pushed a commit that referenced this pull request
@weierophinney weierophinney [#2648] Added note to README.md
- Noted the change in README.md
c3a4d8a
@ghost Unknown pushed a commit that referenced this pull request
@weierophinney weierophinney Merge branch 'hotfix/2648' into develop
Close #2648
2c95fa6
@weierophinney weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request
@weierophinney weierophinney Merge branch 'hotfix/2648' into develop 2015da5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 2, 2012
  1. @demiankatz

    AbstractPluginManager should not respond to ServiceManagerAwareInterf…

    demiankatz committed
    …ace; that is a more specific marker not intended for generic plugins.
Showing with 0 additions and 3 deletions.
  1. +0 −3 library/Zend/ServiceManager/AbstractPluginManager.php
View
3 library/Zend/ServiceManager/AbstractPluginManager.php
@@ -69,9 +69,6 @@ public function __construct(ConfigInterface $configuration = null)
if ($instance instanceof ServiceLocatorAwareInterface) {
$instance->setServiceLocator($self);
}
- if ($instance instanceof ServiceManagerAwareInterface) {
- $instance->setServiceManager($self);
- }
});
}
Something went wrong with that request. Please try again.