Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

importing the fix for ZF-6802 #305

Closed
wants to merge 1 commit into from

2 participants

Robert Basic Matthew Weier O'Phinney
Robert Basic

No description provided.

Matthew Weier O'Phinney

Reviewed, merged, and pushed to master - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 1, 2011
  1. Robert Basic
This page is out of date. Refresh to see the latest.
1  library/Zend/Dojo/View/Helper/Textarea.php
View
@@ -68,7 +68,6 @@ public function direct($id = null, $value = null, array $params = array(), array
$attribs['id'] = $id;
}
$attribs['name'] = $id;
- $attribs['type'] = $this->_elementType;
$attribs = $this->_prepareDijit($attribs, $params, 'textarea');
6 tests/Zend/Dojo/View/Helper/TextareaTest.php
View
@@ -91,4 +91,10 @@ public function testPassingIdAsAttributeShouldOverrideUsingNameAsId()
$html = $this->helper->direct('foo[bar]', '', array(), array('id' => 'foo-bar'));
$this->assertContains('id="foo-bar"', $html);
}
+
+ public function testGeneratedMarkupShouldNotIncludeTypeAttribute()
+ {
+ $html = $this->getElement();
+ $this->assertNotRegexp('/type="text/', $html, $html);
+ }
}
Something went wrong with that request. Please try again.