Skip to content
This repository

importing the fix for ZF-6802 #305

Closed
wants to merge 1 commit into from

2 participants

Robert Basic Matthew Weier O'Phinney
Robert Basic

No description provided.

Matthew Weier O'Phinney
Owner

Reviewed, merged, and pushed to master - thanks!

Matthew Weier O'Phinney weierophinney closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Aug 01, 2011
Robert Basic importing the fix for ZF-6802 a2022ec
This page is out of date. Refresh to see the latest.
1  library/Zend/Dojo/View/Helper/Textarea.php
@@ -68,7 +68,6 @@ public function direct($id = null, $value = null, array $params = array(), array
68 68
             $attribs['id']    = $id;
69 69
         }
70 70
         $attribs['name']  = $id;
71  
-        $attribs['type']  = $this->_elementType;
72 71
 
73 72
         $attribs = $this->_prepareDijit($attribs, $params, 'textarea');
74 73
 
6  tests/Zend/Dojo/View/Helper/TextareaTest.php
@@ -91,4 +91,10 @@ public function testPassingIdAsAttributeShouldOverrideUsingNameAsId()
91 91
         $html = $this->helper->direct('foo[bar]', '', array(), array('id' => 'foo-bar'));
92 92
         $this->assertContains('id="foo-bar"', $html);
93 93
     }
  94
+    
  95
+    public function testGeneratedMarkupShouldNotIncludeTypeAttribute()
  96
+    {
  97
+        $html = $this->getElement();
  98
+        $this->assertNotRegexp('/type="text/', $html, $html);
  99
+    }
94 100
 }
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.