This repository was archived by the owner on Jan 8, 2020. It is now read-only.
[hotfix/ZF2-46] Definition/Compiler marks all setter-injection method arguments as optional#321
Closed
adamlundrigan wants to merge 3 commits into
Closed
[hotfix/ZF2-46] Definition/Compiler marks all setter-injection method arguments as optional#321adamlundrigan wants to merge 3 commits into
adamlundrigan wants to merge 3 commits into
Conversation
Member
|
Don't pull this quite yet; I think the actual issue may be mis-diagnosed here. See my comments on http://framework.zend.com/issues/browse/ZF2-46 |
- Invert logic so that setter injection method arguments aren't all forced to be optional
…or assertions now pass
Contributor
Author
|
Outdated, no longer necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested fix for ZF2-46