This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Zend\Db\TableGateway hotfix for MasterSlaveFeature #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed MasterSlave feature
| * @param ParameterContainer $initialParameters | ||
| * @return Driver\StatementInterface | ||
| */ | ||
| public function createStatement($initialSql = null, $initialParameters = null); |
There was a problem hiding this comment.
Per @ralphschindler - As this is a driver level facility, it should not be in the adapter interface. Additionally, removing a method from an interface is always backwards compatible, so long as implementations do not rely on the existence of the method. Finally, as this only exists on the develop branch, not yet released, we are completely safe removing it.
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed MasterSlave feature, as reported in #3175