Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix bug when $indent have some string #3618

Closed
wants to merge 1 commit into from

2 participants

@iquabius

assuming $ident = '¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨':
before:

¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨<script type="text/javascript">
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //<!--
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    Some script here...¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨
    //-->
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨</script>

now:

¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨<script type="text/javascript">
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //<!--
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    Some script here...
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //-->
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨</script>
@iquabius iquabius Fix bug when $indent have some string
assuming $ident = '¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨';
before:
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨<script type="text/javascript">
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //<!--
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    Some script here...¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨
    //-->
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨</script>

now:
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨<script type="text/javascript">
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //<!--
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    Some script here...
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //-->
¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨</script>
57f8632
@weierophinney weierophinney was assigned
@weierophinney weierophinney referenced this pull request from a commit
@weierophinney weierophinney Merge branch 'hotfix/3618' into develop
Forward port #3618
7f02d7d
@ghost Unknown referenced this pull request from a commit
@weierophinney weierophinney Merge branch 'hotfix/3618'
Close #3618
c072cae
@ghost Unknown referenced this pull request from a commit
@weierophinney weierophinney Merge branch 'hotfix/3618' into develop
Forward port #3618
30aa3e5
@weierophinney weierophinney referenced this pull request from a commit in zendframework/zend-view
@weierophinney weierophinney Merge branch 'hotfix/3618' b9f6e35
@weierophinney weierophinney referenced this pull request from a commit in zendframework/zend-view
@weierophinney weierophinney Merge branch 'hotfix/3618' into develop 9ba1899
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 30, 2013
  1. @iquabius

    Fix bug when $indent have some string

    iquabius authored
    assuming $ident = '¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨';
    before:
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨<script type="text/javascript">
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //<!--
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    Some script here...¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨
        //-->
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨</script>
    
    now:
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨<script type="text/javascript">
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //<!--
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    Some script here...
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨    //-->
    ¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨¨</script>
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  library/Zend/View/Helper/HeadScript.php
View
2  library/Zend/View/Helper/HeadScript.php
@@ -422,7 +422,7 @@ public function itemToString($item, $indent, $escapeStart, $escapeEnd)
$html .= $indent . ' ' . $item->source;
if ($addScriptEscape) {
- $html .= $indent . PHP_EOL . ' ' . $escapeEnd;
+ $html .= PHP_EOL . $indent . ' ' . $escapeEnd;
}
$html .= PHP_EOL . $indent;
Something went wrong with that request. Please try again.