Skip to content

Loading…

[#2899] Remove redundant method declaration #3681

Merged
merged 1 commit into from

2 participants

@weierophinney
Zend Framework member
  • Re-declaring a method as abstract when defined in an interface being implemented can lead to issues under some versions of PHP. Removing the abstract method in the abstract class fixes the issue.

Fixes #2899

@weierophinney weierophinney [#2899] Remove redundant method declaration
- Re-declaring a method as abstract when defined in an interface being
  implemented can lead to issues under some versions of PHP. Removing
  the abstract method in the abstract class fixes the issue.
493130d
@Maks3w Maks3w added a commit that referenced this pull request
@Maks3w Maks3w Forward port #3681 b66adf9
@Maks3w Maks3w merged commit 493130d into zendframework:master

1 check failed

Details default The Travis build could not complete due to an error
@ghost Unknown pushed a commit that referenced this pull request
@Maks3w Maks3w Forward port #3681 4dc1ea0
@gianarb gianarb pushed a commit to zendframework/zend-console that referenced this pull request
@Maks3w Maks3w Merge pull request zendframework/zf2#3681 branch 'hotfix/declare-abst…
…ract-method' Fix zendframework/zf2#2899
6c2eca4
@gianarb gianarb pushed a commit to zendframework/zend-console that referenced this pull request
@Maks3w Maks3w Forward port zendframework/zf2#3681 5ac4be0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 5, 2013
  1. @weierophinney

    [#2899] Remove redundant method declaration

    weierophinney committed
    - Re-declaring a method as abstract when defined in an interface being
      implemented can lead to issues under some versions of PHP. Removing
      the abstract method in the abstract class fixes the issue.
Showing with 0 additions and 7 deletions.
  1. +0 −7 library/Zend/Console/Prompt/AbstractPrompt.php
View
7 library/Zend/Console/Prompt/AbstractPrompt.php
@@ -27,13 +27,6 @@
protected $lastResponse;
/**
- * Show a prompt
- *
- * @return void
- */
- abstract public function show();
-
- /**
* Return last answer to this prompt.
*
* @return mixed
Something went wrong with that request. Please try again.