Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Paginator: Group by must be reseted #3791

Merged
merged 2 commits into from Feb 15, 2013
Merged

Paginator: Group by must be reseted #3791

merged 2 commits into from Feb 15, 2013

Conversation

ThaDafinser
Copy link
Contributor

The group by part has also to be reseted, when COUNT(1) is used

@ThaDafinser
Copy link
Contributor Author

Otherwise the count() result will be wrong.

For reference see ZF1 (there is was correct)

@ralphschindler ralphschindler merged commit 5ddc4e9 into zendframework:master Feb 15, 2013
ralphschindler added a commit that referenced this pull request Feb 15, 2013
@ralphschindler
Forward #3791
dec8ec5 
Merge branch 'ThaDafinser-patch-3' into develop
@ralphschindler
Copy link
Member

There have been improvements to the Zend\Paginator\Adapter\DbSelect that have moved into master (for 2.2.1). Basically, DbSelect moved to a subselect solution, which is more portable. Please see these issues: #4641, #4590, and #3647.

gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@ralphschindler
Forward zendframework/zendframework#3791
616a69c 
Merge branch 'ThaDafinser-patch-3' into develop
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThaDafinser @ralphschindler