Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Remove obsolete catch statement #3806

Closed
wants to merge 1 commit into from

3 participants

@micheh

Since the SymmetricException\InvalidArgumentException extends the CryptException\InvalidArgumentException, there is no need for the second catch statement.

@weierophinney
@ezimuel ezimuel was assigned
@ezimuel
Owner

@weierophinney Generally speaking yes, you should catch SymmetricException and after CryptException. But in this case the code of the catch is the same so we can remove the SymmetricException.

@ghost Unknown referenced this pull request from a commit
@weierophinney weierophinney Merge branch 'hotfix/3806'
Close #3806
1525c95
@ghost Unknown referenced this pull request from a commit
@weierophinney weierophinney Merge branch 'hotfix/3806' into develop
Forward port #3806
9366747
@weierophinney weierophinney referenced this pull request from a commit in zendframework/zend-filter
@weierophinney weierophinney Merge branch 'hotfix/3806' 59d813b
@weierophinney weierophinney referenced this pull request from a commit in zendframework/zend-filter
@weierophinney weierophinney Merge branch 'hotfix/3806' into develop 82a1f14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 17, 2013
  1. @micheh
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 2 deletions.
  1. +0 −2  library/Zend/Filter/Encrypt/BlockCipher.php
View
2  library/Zend/Filter/Encrypt/BlockCipher.php
@@ -251,8 +251,6 @@ public function encrypt($value)
$encrypted = $this->blockCipher->encrypt($value);
} catch (CryptException\InvalidArgumentException $e) {
throw new Exception\InvalidArgumentException($e->getMessage());
- } catch (SymmetricException\InvalidArgumentException $e) {
- throw new Exception\InvalidArgumentException($e->getMessage());
}
return $encrypted;
}
Something went wrong with that request. Please try again.