Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Fixed console routes when using same name for group and parameter #4262

Conversation

robertmarsal
Copy link
Contributor

When using console routes with groups where the name of the group matched a parameter name, like:

'route'    => 'test [-t|--test]:test'

the obtained parameters were incorrect.

@Thinkscape
Copy link
Member

You're right!
Apparently I was mistaken and for some reason it worked for me, but now after more testing I confirm this is a bug. Give me some time to check your PR...

@Thinkscape
Copy link
Member

Looks clear, however please add the following test routes just to be sure:

group (-t | --test ):test
group [-x|-y|-z]:test
group [--foo|--bar|--baz]:test
group (--foo|--bar|--baz):test

weierophinney added a commit that referenced this pull request Apr 22, 2013
Fixed console routes when using same name for group and parameter
weierophinney added a commit that referenced this pull request Apr 22, 2013
@ghost ghost assigned weierophinney Apr 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants