Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

removed checks of not existing class Zend\Math\BigInteger #4633

Merged
merged 1 commit into from

3 participants

@marc-mabe

This addresses the last note of #3512
The second note seems to be fixed already

but the first one is already there and I cant fix:

#grep -iHrn 'ConstraintKeyObject' library/Zend/Db/
../library/Zend/Db/Metadata/Source/AbstractSource.php:398:                $keys[] = $key = new Object\ConstraintKeyObject($constraintKeyInfo['column_name']);

@ralphschindler @Maks3w ping

@Maks3w Maks3w commented on the diff
library/Zend/XmlRpc/Server.php
@@ -79,7 +79,6 @@ class Server extends AbstractServer
'i4' => 'i4',
'int' => 'int',
'integer' => 'int',
- 'Zend\Math\BigInteger' => 'i8',
@Maks3w Collaborator
Maks3w added a note

Why do you remove this?

BigInteger feature is not removed. Just the old deprecated message

If the class doesn't exist it's not possible to get this as PHP type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@ezimuel ezimuel merged commit 7ce2dba into from
@marc-mabe marc-mabe deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
14 library/Zend/XmlRpc/AbstractValue.php
@@ -10,7 +10,6 @@
namespace Zend\XmlRpc;
use DateTime;
-use Zend\Math\BigInteger;
/**
* Represent a native XML-RPC value entity, used as parameters for the methods
@@ -277,17 +276,8 @@ public static function getXmlRpcTypeByValue($value)
protected static function _phpVarToNativeXmlRpc($value)
{
// @see http://framework.zend.com/issues/browse/ZF-8623
- if (is_object($value)) {
- if ($value instanceof AbstractValue) {
- return $value;
- }
- if ($value instanceof BigInteger) {
- throw new Exception\InvalidArgumentException(
- 'Using Zend\Math\BigInteger to get an ' .
- 'instance of Value_BigInteger is not ' .
- 'available anymore.'
- );
- }
+ if ($value instanceof AbstractValue) {
+ return $value;
}
switch (static::getXmlRpcTypeByValue($value)) {
View
1  library/Zend/XmlRpc/Server.php
@@ -79,7 +79,6 @@ class Server extends AbstractServer
'i4' => 'i4',
'int' => 'int',
'integer' => 'int',
- 'Zend\Math\BigInteger' => 'i8',
@Maks3w Collaborator
Maks3w added a note

Why do you remove this?

BigInteger feature is not removed. Just the old deprecated message

If the class doesn't exist it's not possible to get this as PHP type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
'i8' => 'i8',
'ex:i8' => 'i8',
'double' => 'double',
Something went wrong with that request. Please try again.