Skip to content

Loading…

PHP 5.5 can't fail anymore #4700

Closed
wants to merge 1 commit into from

5 participants

@Slamdunk

With the release of the first stable PHP 5.5 version, travis is no more allowed to fail.

@marc-mabe
Zend Framework member

As you can see the travis is on PHP 5.5.0RC3 - so we have to wait as long as travis updated the PHP version

@Slamdunk

PHP 5.5 is on stable now in travis:

PHP 5.5.0 (cli) (built: Jun 21 2013 15:37:05)
Copyright (c) 1997-2013 The PHP Group
Zend Engine v2.5.0-dev, Copyright (c) 1998-2013 Zend Technologies
    with Zend OPcache v7.0.2-dev, Copyright (c) 1999-2013, by Zend Technologies
    with Xdebug v2.2.3, Copyright (c) 2002-2013, by Derick Rethans
@weierophinney
Zend Framework member

@Slamdunk Are you willing to fix the issues on 5.5 as well? (Just kidding!) Thanks for the update; will merge later.

@mwillbanks

@weierophinney should we merge this now or fix the failing test first :)

@Slamdunk

@mwillbanks definitely merge: tests should be fixed only when they fail. A red test in a green testsuite run is NOT a fail :wink:

@weierophinney
Zend Framework member

I'd argue that as part of merging, we should attempt to address the failing tests.

The problem is: I've tried. When I ran the tests locally, they ran fine, and I could not reproduce the failures seen on Travis. This means we likely need to skip them in Travis -- but I don't like that solution, in case there's something fundamentally wrong.

@mwillbanks Thoughts?

@mwillbanks

@weierophinney when i started running them last night I had a ton of failures; way more than travis did (likely my configuration and extensions) so I was attempting to hone those in first but ran out of time last night. I might boot up a machine today just for running some of the tests.

@Maks3w
Zend Framework member

At this moment there is only one "passive" test failure with PHP 5.5

https://travis-ci.org/zendframework/zf2/jobs/9172993#L546

Some volunteer for fix it?

@marc-mabe
Zend Framework member

This is a test for not running into an infinite loop on self references. PHP < 5.5 automatically skip the first found self reference with null but PHP >= 5.5 they write in the man 5.5.0 depth parameter was added.

But using json_encode has other issues I think. (What if you don't log UTF-8 messages?)
Could we remove json_encode and format it using print_r or var_export eventually with an additional preg_replace to reformat line breaks?

EDIT Or of course serialize could be another candidate, too.

@weierophinney weierophinney added a commit that referenced this pull request
@weierophinney weierophinney Merge branch 'hotfix/4700' into develop
Forward port #4700
957d278
@weierophinney weierophinney added a commit that closed this pull request
@weierophinney weierophinney Merge branch 'hotfix/4700'
Close #4700
3d2232d
@weierophinney weierophinney added a commit to zendframework/zend-log that referenced this pull request
@weierophinney weierophinney Merge branch 'hotfix/4700' bcb4d03
@weierophinney weierophinney added a commit to zendframework/zend-log that referenced this pull request
@weierophinney weierophinney Merge branch 'hotfix/4700' into develop ff36689
@weierophinney weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request
@weierophinney weierophinney Merge pull request zendframework/zf2#4700 from Slamdunk/patch-2
PHP 5.5 can't fail anymore
25dc083
@weierophinney weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request
@weierophinney weierophinney Merge branch 'hotfix/4700' f380ca1
@weierophinney weierophinney added a commit to zendframework/zend-i18n-resources that referenced this pull request
@weierophinney weierophinney Merge branch 'hotfix/4700' into develop 7cac91c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 17, 2013
  1. @Slamdunk

    PHP 5.5 can't fail anymore

    Slamdunk committed
Showing with 0 additions and 4 deletions.
  1. +0 −4 .travis.yml
View
4 .travis.yml
@@ -6,10 +6,6 @@ php:
- 5.4
- 5.5
-matrix:
- allow_failures:
- - php: 5.5
-
before_install:
- cp tests/TestConfiguration.php.travis tests/TestConfiguration.php
Something went wrong with that request. Please try again.