Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Revise docblocks in Zend\Session\ContainerAbstractServiceFactory #4981

Closed
wants to merge 1 commit into from

2 participants

@pwarnock

Docblocks indicate usage of SessionConainer\ prefix

33  * Services use the prefix "SessionContainer\\":                                
34  *                                                                              
35  * <code>                                                                       
36  * $container = $services->get('SessionContainer\captcha');                     
37  * </code>                

and that normalizeContainerName strips off the prefix

141      *                                                                          
142      * Strips off the "SessionContainer\" prefix, and lowercases the name.      
143      *    

Docblocks revised to show sample configuration without stripping prefix.

@weierophinney

Actually... docblocks are legacy in this case; that was the original intent, but during review of the code, we decided to drop the prefixing.

So... I'll only accept this if you revert the code changes and instead remove the information in the docblocks.

@pwarnock

@weierophinney Thanks for the feedback.

@pwarnock pwarnock deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
12 library/Zend/Session/Service/ContainerAbstractServiceFactory.php
@@ -23,17 +23,15 @@
* <code>
* return array(
* 'session_containers' => array(
- * 'auth',
- * 'user',
- * 'captcha',
+ * 'SessionContainer\sample',
+ * 'my_sample_session_container',
+ * 'MySessionContainer',
* ),
* );
* </code>
*
- * Services use the prefix "SessionContainer\\":
- *
* <code>
- * $container = $services->get('SessionContainer\captcha');
+ * $container = $services->get('MySessionContainer');
* </code>
*/
class ContainerAbstractServiceFactory implements AbstractFactoryInterface
@@ -139,8 +137,6 @@ protected function getSessionManager(ServiceLocatorInterface $services)
/**
* Normalize the container name in order to perform a lookup
*
- * Strips off the "SessionContainer\" prefix, and lowercases the name.
- *
* @param string $name
* @return string
*/
Something went wrong with that request. Please try again.