CS fix for #5245

[stefanotorresi]

The fixes done during #5245 merge had to be, well... fixed! :p

[stefanotorresi]

ha! if cs fix is applied to the test classes (which is what this PR does), the tests fail because the fixer alters the argument of the assertions.

possible solutions:

• revert cs fix on tests too (this pr did revert it only for the test assets), and then add the two classes to the .php_cs ignore list.
• update the test assets to work with cs-fixed tests.

i'll wait for comments.

[weierophinney]

When I run php-cs-fixer after these changes, it still highlights FunctionReflectionTest.php, MethodReflectionTest.php, and TestAsset/closures.php. The tests still run after updating those, however. Shall I go ahead and apply those changes and finish the merge?

[stefanotorresi]

Hmm that's odd. Have you tried running it via check-cs.sh ?

[weierophinney]

@stefanotorresi Yes, of course. And those are the files it highlights -- tailing spaces and function_declaration errors on the first 2, and braces and function_declaration errors on the last.

[weierophinney]

@stefanotorresi actually... I have a script that goes and runs php-cs-fixer on any files that have changed from the branch I merged against. Evidently, php-cs-fixer does not consult the .php_cs file when you do that, or ignores it when the argument is a file and not a directory. We're good to go here.

[stefanotorresi]

ok then :)
for the record, it is exactly as you said: php-cs-fixer only evaluates .php_cs if it's contained in the directory passed as an argument, so running it on single files or subdirectories won't work.