Fixes CS latest build on travis : develop #7079
Conversation
samsonasik
changed the title
| @@ -248,7 +248,7 @@ public function columns(array $columns, $prefixColumnsWithTable = true) | |||
| * @throws Exception\InvalidArgumentException | |||
| * @return Select | |||
| */ | |||
| public function join($name, $on, $columns = self::SQL_STAR, $type = self::JOIN_INNER) | |||
| public function implode($name, $on, $columns = self::SQL_STAR, $type = self::JOIN_INNER) | |||
There was a problem hiding this comment.
oh, it should be added into .php_cs...
|
I've undo change "join" to "implode" function of library/Zend/Db/Sql/Select.php and added it to .php_cs config in notPath... |
| @@ -128,7 +128,7 @@ public function testFetchMessageBody() | |||
| $mail = new MaildirOldMessage(array('dirname' => $this->_maildir)); | |||
|
|
|||
| $content = $mail->getMessage(3)->getContent(); | |||
| list($content,) = explode("\n", $content, 2); | |||
| list($content, ) = explode("\n", $content, 2); | |||
There was a problem hiding this comment.
@Ocramius it makes cs error with "parenthesis" cs, but when it trimmed, it makes another error : "method_argument_space", should these files added to .php_cs too ?
There was a problem hiding this comment.
@samsonasik why not just removing the commas? I'll give that a shot first.
|
Manually merged after applying the comma changes. Thanks @samsonasik!
|
|
thank you. travis still failure... it seems |
|
or maybe in latest travis build https://travis-ci.org/zendframework/zf2/builds/45305386 seems still show old behaviour... |
ping @Ocramius . pointed to develop. should be green after pr #7078 merged to master and develop.