This repository was archived by the owner on Jan 8, 2020. It is now read-only.
[ZF2-176] Replace all assertType assertions.#836
Merged
Conversation
Member
|
Request reviewed - except for PHPUnit method renames for 3.6 there are no other material changes. |
Member
|
Request pending confirmation that we will upgrade test dependency to PHPUnit 3.6 ;). Bear with us. |
Member
Author
|
Upgrade to 3.6 is not required. This changes are backward compatible with the oficial PHPUnit version for ZF2 (3.5.x) |
Member
|
Understood, however we have other test incompatibilities and I'm going through the whole suite so we're waiting for the 3.6 confirm before merging in any bulk changes. |
padraic
pushed a commit
that referenced
this pull request
Feb 25, 2012
[ZF2-176] Replace all assertType assertions.
gianarb
pushed a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
…/ZF2-176 [ZF2-176] Replace all assertType assertions.
gianarb
pushed a commit
to zendframework/zend-paginator
that referenced
this pull request
May 15, 2015
…/ZF2-176 [ZF2-176] Replace all assertType assertions.
gianarb
pushed a commit
to zendframework/zend-http
that referenced
this pull request
May 15, 2015
…/ZF2-176 [ZF2-176] Replace all assertType assertions.
gianarb
pushed a commit
to zendframework/zend-feed
that referenced
this pull request
May 15, 2015
…/ZF2-176 [ZF2-176] Replace all assertType assertions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced every assertType ocurrence in the code with assertInstanceOf or assertInternalType depending if was asserting a class or a PHP's primitive type
This change is according to the PHPUnit's API changes where assertType was declared as deprecated in PHPUnit 3.5 and finally was removed in 3.6