added bpm 2.0 #297
Merged
added bpm 2.0 #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git literally tells you exactly why :) |
dumbmatter
reviewed
Aug 31, 2020
| BPM[i] += teamAdjBPM[players[i].tid]; | ||
| OBPM[i] += teamAdjOBPM[players[i].tid]; | ||
| DBPM[i] = BPM[i] - OBPM[i]; | ||
| VORP[i] = playerMin[i] * BPM[i]; |
There was a problem hiding this comment.
https://www.basketball-reference.com/about/bpm2.html says VORP is [BPM - (-2.0)] * (% of possessions played) * (team games/82), looks like this is missing the constant (just scales it up) and the team games part (makes it so that players don't immediately have huge VORPs after 1 game in the season).
I'll fix it, just wanted to make sure this wasn't intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure why it can't merge. likely some small recent UI updates.