Merged
Conversation
Member
|
Another argument in favor of eFG% is that it's actually already in the game... it's one of the "four factors" shown in box scores. But that's in part because FT rate is another one of the four factors, which puts it in context. Change "EFG%" to "eFG%" and I think I'll merge it, why not... |
Contributor
Author
|
that capital E did bother me as well lol, i was too lazy to change it |
Member
|
Thanks, probably will deploy later today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know you said you aren't sure if people still care about it, but I'm still making the PR lol. There are people who blow it off as poor mans TS% but I still see it brought up occasionally on discussion forums. Also, adding this will give the per game section everything bball ref has!
I'm sure some will appreciate this... such as myself lol