God mode option to change number of fouls needed for bonus#351
Merged
dumbmatter merged 3 commits intozengm-games:hockeyfrom Feb 7, 2021
Merged
God mode option to change number of fouls needed for bonus#351dumbmatter merged 3 commits intozengm-games:hockeyfrom
dumbmatter merged 3 commits intozengm-games:hockeyfrom
Conversation
Member
|
Thanks!
4d8e6ee is what kind of solves that... although it's very annoying to keep that manually in sync with TypeScript, and the error message it gives is horrible. But it's something... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/290013534023057409/331882115119448065/805026506283810847
Works well, allows more ability to recreate the rules of other basketball leagues
I went with the approach of forcing it all in one setting because 3 individual settings would be redundant. No bugs have emerged from this. Although it is possible to enter an invalid setting in a league file, it does not break leagues or game sim.