Options to configure min/max age of draft prospects and force retire players at certain age #354

domini7 · 2021-02-07T11:04:37Z

Draft ages can really mess up the talent of a league if they aren't close to the default. Prospects below the default min age (19) seems to be just as good as default, which absolutely balloons the talent. IMO would be better if somehow they would be generated with worse ratings. - touched up in 499c58b

Something I want to do about force retire but not sure how, when importing a league file with it set to a number (lets say 32), I want to make sure the league does NOT generate players older than 32. Right now it does which is awkward.

Just like any other extreme god mode option (death rate, gamesim settings), people can make their leagues wonky, but nothing wrong with that.

Other than all that, fun, cool, highly requested feature! Allows to copy some international leagues that allow 16 year olds, or the WNBA which only allows seniors.

dumbmatter · 2021-02-07T17:29:59Z

Ages of draft prospects is a good idea, if you can make the ratings behave reasonably (like I see you talking about on Discord).

Force retire age... what's the use case? To simulate college sports? If that's it, then there are so many other differences with college sports, I'm not sure it's worth adding. It would still be unsatisfying.

domini7 · 2021-02-07T17:38:53Z

Force retire age... what's the use case?

I've been playing with a league with it set to 25 where there's constantly new generations of players. It's really interesting honestly, the dynamic of having to play around the fact that my star player won't be around for much longer, drafting the youngest players are key. Fun things to do with it. Simulating a college league is partly possible which is neat, but it can go deeper. Simulate a freakin middle school league. U11 leagues. Possibilities are endless with what people can do with that option

domini7 · 2021-02-07T17:42:07Z

If that's it, then there are so many other differences with college sports

This can be said with any other leagues that aren't NBA, like Europe leagues, FIBA. Yet, people still create those leagues for BBGM with teams and league structure despite not being able to fully recreate what those leagues offer.

domini7 · 2021-02-07T17:56:45Z

U11 rec league with 8 draft rounds and prospects aged 9-10 is actually pretty fun

dumbmatter · 2021-02-07T18:16:07Z

Okay, that convinces me enough.

About players in new leagues, the way it works is it simulates 20 past drafts to generate all the players https://github.com/dumbmatter/gm-games/blob/d3554459319bf558c44ff3bf092df30da06dc740/src/worker/core/league/create.ts#L471

In your use case, I guess you wouldn't need 20 past drafts. But you'd need more rounds per draft to compensate... might need better error handling in that case, to automatically increase that value, or people will find it annoying.

…age-gen Pulling master

domini7 · 2021-02-08T12:50:53Z

That last commit needs some work to make it less repetitive. I tried to declare an array of ratings then looping to subtract but I get an error.

const rtgs = ["spd", "jmp]
for (rtg of rtgs) {
    ratings[rtg] -= subAmount;
}

When running lint, I get
Element e 'any' can't be used to index type '{ stre: number; spd: number; jmp: number; g: number; tp: number; oiq: number; diq: number; drb: number; pss: number; reb string; pot: number; season: number; skills: never[]; }'.
I tried googling but I can't figure it out!

domini7 · 2021-02-08T13:01:02Z

ageDraft command is complete and works pretty well with scaling

…age-gen Pull bug fix

dumbmatter · 2021-03-14T03:28:54Z

That last commit needs some work to make it less repetitive. I tried to declare an array of ratings then looping to subtract but I get an error.
const rtgs = ["spd", "jmp]
for (rtg of rtgs) {
    ratings[rtg] -= subAmount;
}
When running lint, I get
Element e 'any' can't be used to index type '{ stre: number; spd: number; jmp: number; g: number; tp: number; oiq: number; diq: number; drb: number; pss: number; reb string; pot: number; season: number; skills: never[]; }'.
I tried googling but I can't figure it out!

When you write something like const rtgs = ["spd", "jmp"];, TypeScript interprets it as "array of strings". So then in ratings[rtg], all it knows is that rtg is a string, and yet it also knows that ratings only accepts a limited subset of strings as keys. That's what the error is about.

Easiest fix is to change it the array declaration to const rtgs = ["spd", "jmp"] as const;, which tells TypeScript "this isn't any old array of strings, it is a specific array containing only the elements spd and jmp". Then when you call ratings[rtg] it knows that is safe.

dumbmatter · 2021-03-14T03:30:14Z

Also can you give me write access to this branch (or your whole repo)? I haven't actually done anything, but I want to look at this soon, and might be easier if I can push a commit to the PR branch.

…e draft class size

dumbmatter · 2021-03-27T17:57:56Z

src/worker/core/player/genRatings.basketball.ts

+	// If the youngest players generated aren't 19, scale ratings to match age
+	const age = g.get("draftAge")[0];
+	if (age !== 19) {
+		// Youngest prospects != 19 will be scaled, scaling stops at age 14 and 28


Can you take another look at all these?

Basketball is currently scaled from 12 to 28, not 14 to 28

Football is currently scaled from 14 to 30, not 14 to 28

Hockey is currently scaled just like basketball, but I'm not sure if that's intended because in the other two sports you use the same age in the scale formula as in the if right before it. If it's intended for those two numbers to always be the same, use a constant like const DEFAULT_MIN_AGE = 19; (different in each file). That prevents them from ever getting out of sync.

If the goal was to have all the age ranges the same for every sport, like the comments suggest, I recommend you put the helpers.bound around age, not around the entire scale formula. Then it'll be much more clear what's going on.

good eye, give me a minute

Ok so some reasoning behind these numbers if you aren't sure. I set the min max age scaling limits to prevent super leagues (So not every prospect is a 90 OVR demigod for 35 year old DP's) and to prevent trash prospects with a rating of 0 in every single rating. So hitting the max scaling will produce a class that looks like a typical league (few studs, lot of role players), and the min scaling will at least give some promising players instead of everyone being absolute trash.

dumbmatter · 2021-03-27T19:20:55Z

src/worker/core/player/genRatings.hockey.ts

@@ -198,6 +198,37 @@ const genRatings = (
 		pots: { ...defaultOvrsOrPots },
 	};

+	// Youngest prospects !== 18 will be scaled, scaling stops at age 13 and 26
+	let age = g.get("draftAges")[0];
+	age = helpers.bound(age, 13, 26);


Why different than other sports?

When I left it the same as BBGM/FBGM, there were an absurd absurd number of superstars. Players below the min scaling were also a bit too good.

dumbmatter · 2021-03-27T19:40:22Z

src/worker/core/player/genRatings.basketball.ts

+			"diq",
+		] as const;
+		// These ratings develop slowly compared to others, so they scale less. Works well in testing
+		const rtgsDevelopSlow = ["spd", "jmp", "drb", "pss", "reb"];


Don't fix it, I'm doing it, but... these are never getting applied!

dumbmatter · 2021-03-27T20:20:01Z

src/worker/core/player/genRatings.football.ts

@@ -357,6 +357,43 @@ const genRatings = (
 		pots: { ...defaultOvrsOrPots },
 	};

+	// Youngest prospects !== 21 will be scaled, scaling stops at age 14 and 30
+	let age = g.get("draftAges")[0];
+	age = helpers.bound(age, 14, 30);


I understand why you want an upper bound (because at some age, players stop development, so continuing to boost them after that would make super players).

But why do you want a lower bound? No matter how low a player's age, he's still going to be improving every year.

it is subjective, but ages under 10 have a lot of 0 ovr players, so it's not rly fun if you want to do some little kid league and have to deal with most of the players being incompetent (maybe realistic). Bigger thing, if everyone becomes 0 OVR, everyone will end up developing in very similar styles and only be separated by height rating.

you could lower it or remove it if you believe its better, i just didn't really like it without a min limit

…ly check the distribution of ovr for various draftAges

dumbmatter · 2021-03-27T21:12:57Z

Did a little refactoring (moving the age adjustment code to one place for all sports), lmk if it looks okay.

Also made the lower bound of the adjustment unbounded, but still small enough at 0 that you get some diversity of players.

Also did this fun thing, for displaying the 1st quartile, median, and 3rd quartile ovr ratings at different draftAges values:

$ SPORT=basketball yarn jest src/worker/core/player/genRatings.test.ts | grep QUARTILES
PASS src/worker/core/player/genRatings.test.ts (51.776 s)
  worker/core/player/genRatings
    ✓ no error with restricted draftAges and forceRetireAge settings (50079 ms)

    QUARTILES at default [ 31, 57, 74 ]
    QUARTILES at age  0  [ 29, 57, 76 ]
    QUARTILES at age  5  [ 29, 57, 77 ]
    QUARTILES at age 10  [ 34, 60, 75 ]
    QUARTILES at age 15  [ 36, 55, 63 ]
    QUARTILES at age 20  [ 40, 47, 55 ]
    QUARTILES at age 25  [ 31, 36, 43 ]
    QUARTILES at age 30  [ 27, 34, 45 ]
    QUARTILES at age 35  [ 20, 28, 37 ]
    QUARTILES at age 40  [ 17, 22, 34 ]
    QUARTILES at age 45  [ 16, 22, 33 ]
Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        52.144 s
Ran all test suites matching /src\/worker\/core\/player\/genRatings.test.ts/i.
$ SPORT=football yarn jest src/worker/core/player/genRatings.test.ts | grep QUARTILES
PASS src/worker/core/player/genRatings.test.ts (29.417 s)
  worker/core/player/genRatings
    ✓ no error with restricted draftAges and forceRetireAge settings (27772 ms)

    QUARTILES at default [ 38, 46, 55 ]
    QUARTILES at age  0  [ 51, 62, 75 ]
    QUARTILES at age  5  [ 56, 67, 78 ]
    QUARTILES at age 10  [ 59, 69, 78 ]
    QUARTILES at age 15  [ 54, 61, 69 ]
    QUARTILES at age 20  [ 41, 49, 57 ]
    QUARTILES at age 25  [ 25, 30, 37 ]
    QUARTILES at age 30  [ 21, 27, 34 ]
    QUARTILES at age 35  [ 17, 20, 27 ]
    QUARTILES at age 40  [ 17, 20, 26 ]
    QUARTILES at age 45  [ 16, 20, 26 ]
Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        29.793 s, estimated 52 s
Ran all test suites matching /src\/worker\/core\/player\/genRatings.test.ts/i.
$ SPORT=hockey yarn jest src/worker/core/player/genRatings.test.ts | grep QUARTILES
PASS src/worker/core/player/genRatings.test.ts (8.531 s)
  worker/core/player/genRatings
    ✓ no error with restricted draftAges and forceRetireAge settings (6876 ms)

    QUARTILES at default [ 43, 50, 57 ]
    QUARTILES at age  0  [ 26, 43, 61 ]
    QUARTILES at age  5  [ 32, 48, 64 ]
    QUARTILES at age 10  [ 37, 50, 64 ]
    QUARTILES at age 15  [ 40, 50, 59 ]
    QUARTILES at age 20  [ 45, 49, 56 ]
    QUARTILES at age 25  [ 40, 46, 51 ]
    QUARTILES at age 30  [ 35, 42, 50 ]
    QUARTILES at age 35  [ 28, 37, 45 ]
    QUARTILES at age 40  [ 24, 31, 42 ]
    QUARTILES at age 45  [ 23, 28, 40 ]
Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        8.899 s, estimated 30 s
Ran all test suites matching /src\/worker\/core\/player\/genRatings.test.ts/i.

Maybe football needs a more severe penalty for young players...

domini7 · 2021-03-27T21:23:29Z

looks good 👍

domini7 · 2021-03-27T23:49:03Z

I'm assuming you didn't mean to leave default at [0, 0], but if you did then myb

…a new league. Previously, if draftAge was [0,0] the oldest player was 20

…e-gen

dumbmatter · 2021-03-28T00:23:44Z

I made one more commit f1b5530 which tweaks the aging parameter for FBGM and also improves the age distribution in new leagues.

It's definitely not perfect, some settings do weird things, the parameters could still be tuned better. But I think it's good enough to release now. I'll just wait for you to give the final approval, boss!

domini7 · 2021-03-28T00:26:26Z

**Release**

domini7 added 7 commits February 7, 2021 01:54

God mode option: Force retire at age

b9c01ea

God mode option: Draft Ages

bb526dc

Force retire won't work if it is less than max draft age

9968408

Edit description

eef5123

Lint

0bb7478

Specify 'generated' in draftAge description

e3b7825

Force retire god mode only

3c0e7f5

domini7 added 2 commits February 7, 2021 18:29

Cut off players generated at retire age

a19b8c3

Merge branch 'master' of https://github.com/dumbmatter/gm-games into …

b88231c

…age-gen Pulling master

domini7 changed the base branch from hockey to master February 8, 2021 10:43

domini7 added 2 commits February 8, 2021 02:57

More strict checking

c43b2ae

Scale generated ratings if min draftAge is modified

499c58b

Fix issue where oldest dp's can only be 4 years older than youngets

b8f947f

domini7 added 4 commits February 8, 2021 14:56

Merge branch 'master' of https://github.com/dumbmatter/gm-games into …

502320f

…age-gen Pull bug fix

Limit rating scaling at 14, 28

3c730fe

Revise comment for football scaling

daa3b9d

Fix conflict

3f5551d

domini7 added 4 commits March 20, 2021 12:50

Cleaner code

29ec7a7

Rewrite ForceRetire description

65dc623

Remove extra if statement

f16aa00

Bound ratings between 0 and 100

367ad28

dumbmatter added 4 commits March 27, 2021 11:32

When necessary based on draftAge and forceRetireAge settings, increas…

1b0aa85

…e draft class size

Automated test

a0d9f0e

No need for seasonsSimmed to ever be beyond 20

e5331cd

Fix

be7af9a

dumbmatter reviewed Mar 27, 2021

View reviewed changes

dumbmatter and others added 3 commits March 27, 2021 14:19

draftAge -> draftAges

8504232

refactor age scaling

930eab8

fix conflict

404cf1e

dumbmatter reviewed Mar 27, 2021

View reviewed changes

Refactor because DRY

edee64b

dumbmatter reviewed Mar 27, 2021

View reviewed changes

dumbmatter added 3 commits March 27, 2021 15:58

Better default for young basketball

2b9b26e

Better default for young football

4bc2232

Better default for young hockey

f10d772

dumbmatter reviewed Mar 27, 2021

View reviewed changes

dumbmatter added 2 commits March 27, 2021 17:05

Remove lower bound on age scaling, and add genRatings.test.ts to easi…

80a07d0

…ly check the distribution of ovr for various draftAges

Seems okay with same upper limit in all sports

87eb6f2

dumbmatter and others added 2 commits March 27, 2021 19:25

Tweak age scaling

74cfe64

set default back to [19, 22]

d75c030

domini7 and others added 4 commits March 27, 2021 16:56

Lint

6d99cb1

When draftAge is very low, create some older players when generating …

f1b5530

…a new league. Previously, if draftAge was [0,0] the oldest player was 20

Lint

9e08eea

Merge branch 'age-gen' of https://github.com/domini7/gm-games into ag…

8e54346

…e-gen

dumbmatter merged commit d714359 into zengm-games:master Mar 28, 2021

domini7 deleted the age-gen branch April 1, 2021 17:06

Options to configure min/max age of draft prospects and force retire players at certain age #354

Options to configure min/max age of draft prospects and force retire players at certain age #354

Uh oh!

Conversation

domini7 commented Feb 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dumbmatter commented Feb 7, 2021

Uh oh!

domini7 commented Feb 7, 2021

Uh oh!

domini7 commented Feb 7, 2021

Uh oh!

domini7 commented Feb 7, 2021

Uh oh!

dumbmatter commented Feb 7, 2021

Uh oh!

domini7 commented Feb 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

domini7 commented Feb 8, 2021

Uh oh!

dumbmatter commented Mar 14, 2021

Uh oh!

dumbmatter commented Mar 14, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dumbmatter commented Mar 27, 2021

Uh oh!

domini7 commented Mar 27, 2021

Uh oh!

domini7 commented Mar 27, 2021

Uh oh!

dumbmatter commented Mar 28, 2021

Uh oh!

domini7 commented Mar 28, 2021

Uh oh!

Uh oh!

domini7 commented Feb 7, 2021 •

edited

Loading

domini7 commented Feb 8, 2021 •

edited

Loading