Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanos Mode #360

Merged
merged 12 commits into from
Feb 12, 2021
Merged

Thanos Mode #360

merged 12 commits into from
Feb 12, 2021

Conversation

domini7
Copy link
Contributor

@domini7 domini7 commented Feb 12, 2021

At the end of playoffs, there is a 20% chance the league gets snapped. Challenge mode. Wrecks a league, fun for the whole family.

Copy link
Member

@dumbmatter dumbmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will be fun :) Are still working on a 2 year grace period? Do you think that's really required? Is it really a problem if this happens multiple times in a row?

src/worker/core/phase/newPhaseBeforeDraft.ts Outdated Show resolved Hide resolved
]);
console.log(activePlayers.length);
for (let i = 0; i < activePlayers.length / 2; i++) {
await player.killOne(conditions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this result in too many notifications popping up? Would it be better combining them into one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you'll get a death notification for each of your players that died but it seems to limit it to only 4 shown at a time, so it doesn't seem worth it to notify for each player.

src/worker/api/index.ts Outdated Show resolved Hide resolved
@domini7
Copy link
Contributor Author

domini7 commented Feb 12, 2021

Thanks, this will be fun :) Are still working on a 2 year grace period? Do you think that's really required? Is it really a problem if this happens multiple times in a row?

IMO it's an issue because if it happens 2 or 3 times in a row, the talent will be absolutely terrible in a league, you'll see 10 OVR players asking for the max. Most teams will have 0 OVR, it just makes things pretty janky.

@domini7
Copy link
Contributor Author

domini7 commented Feb 12, 2021

Ignore those last 4 commits :)))

@dumbmatter dumbmatter merged commit 6ef13fc into zengm-games:master Feb 12, 2021
@domini7 domini7 deleted the thanos branch February 13, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants