Skip to content

Thanos Mode#360

Merged
dumbmatter merged 12 commits into
zengm-games:masterfrom
domini7:thanos
Feb 12, 2021
Merged

Thanos Mode#360
dumbmatter merged 12 commits into
zengm-games:masterfrom
domini7:thanos

Conversation

@domini7

@domini7 domini7 commented Feb 12, 2021

Copy link
Copy Markdown
Contributor

At the end of playoffs, there is a 20% chance the league gets snapped. Challenge mode. Wrecks a league, fun for the whole family.

@dumbmatter dumbmatter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will be fun :) Are still working on a 2 year grace period? Do you think that's really required? Is it really a problem if this happens multiple times in a row?

Comment thread src/worker/core/phase/newPhaseBeforeDraft.ts Outdated
]);
console.log(activePlayers.length);
for (let i = 0; i < activePlayers.length / 2; i++) {
await player.killOne(conditions);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this result in too many notifications popping up? Would it be better combining them into one?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you'll get a death notification for each of your players that died but it seems to limit it to only 4 shown at a time, so it doesn't seem worth it to notify for each player.

Comment thread src/worker/api/index.ts Outdated
@domini7

domini7 commented Feb 12, 2021

Copy link
Copy Markdown
Contributor Author

Thanks, this will be fun :) Are still working on a 2 year grace period? Do you think that's really required? Is it really a problem if this happens multiple times in a row?

IMO it's an issue because if it happens 2 or 3 times in a row, the talent will be absolutely terrible in a league, you'll see 10 OVR players asking for the max. Most teams will have 0 OVR, it just makes things pretty janky.

@domini7

domini7 commented Feb 12, 2021

Copy link
Copy Markdown
Contributor Author

Ignore those last 4 commits :)))

@dumbmatter dumbmatter merged commit 6ef13fc into zengm-games:master Feb 12, 2021
@domini7 domini7 deleted the thanos branch February 13, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants