Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from vector to Array from primitive (WIP) #14

Closed
wants to merge 2 commits into from
Closed

Switch from vector to Array from primitive (WIP) #14

wants to merge 2 commits into from

Conversation

taktoa
Copy link
Contributor

@taktoa taktoa commented Sep 16, 2017 •
edited

Working on fixing #3.

I figure that it's a good idea to make a pull request as soon as I start on a feature/change, to keep everyone up to date, and to allow me to make use of the Hydra CI.

@zenhack zenhack mentioned this pull request Sep 23, 2017
Merged
@taktoa
Copy link
Contributor Author

taktoa commented Sep 23, 2017

Remaining work:

  • Move array utilities into a separate (non-exposed) module.
  • Improve efficiency of arrayMapM_ (currently it needlessly builds up a list and then throws it away).
  • Fix Show instance on Message.

@taktoa taktoa mentioned this pull request Oct 10, 2017
Open
@zenhack
Copy link
Owner

zenhack commented Apr 23, 2018

I decided to stick with vector, and just closed #3; see the comments there. I'm going to close this as well.

@zenhack zenhack closed this Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@taktoa @zenhack