Add checkbox component #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cahllagerfeld
commented
Apr 9, 2024
| {...props} | ||
| > | ||
| <CheckboxPrimitive.Indicator className={cn("flex items-center justify-center text-current")}> | ||
| <svg |
Collaborator
Author
There was a problem hiding this comment.
I needed to hard embed the svg here, in case we need a more flexible usecase in the future, I also exported the base primitives CheckboxRoot and CheckboxIndicator
Contributor
There was a problem hiding this comment.
I think for the moment it is enough embedding the svg but we have to find a way to "componentise" the icons. 🤔
atzin-escandia
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
✨ add checkbox component
Checklist
Please make sure that your pull request complies with the following requirements:
Code Quality:
Testing:
Documentation:
Review:
Security:
Screenshots (optional)