From d93d9b939bdecb4de1ef5cb63d66ca2312c6b703 Mon Sep 17 00:00:00 2001 From: Hamza Tahir Date: Thu, 13 Mar 2025 15:31:48 +0100 Subject: [PATCH 1/2] Fixed import errors --- gamesense/pipelines/train_accelerated.py | 6 +++++- gamesense/run.py | 4 ++-- gamesense/steps/__init__.py | 2 +- gamesense/steps/finetune.py | 5 ----- 4 files changed, 8 insertions(+), 9 deletions(-) diff --git a/gamesense/pipelines/train_accelerated.py b/gamesense/pipelines/train_accelerated.py index 6d7de4b16..de05601ea 100644 --- a/gamesense/pipelines/train_accelerated.py +++ b/gamesense/pipelines/train_accelerated.py @@ -18,12 +18,13 @@ from steps import ( evaluate_model, - finetune_accelerated, + finetune, log_metadata_from_step_artifact, prepare_data, promote, ) from zenml import pipeline +from zenml.integrations.huggingface.steps import run_with_accelerate @pipeline @@ -75,6 +76,9 @@ def llm_peft_full_finetune( id="log_metadata_evaluation_base", ) + finetune_accelerated = run_with_accelerate( + finetune, num_processes=2, multi_gpu=True, mixed_precision="bf16" + ) ft_model_dir = finetune_accelerated( base_model_id=base_model_id, dataset_dir=datasets_dir, diff --git a/gamesense/run.py b/gamesense/run.py index db5f637b1..8b56d7073 100644 --- a/gamesense/run.py +++ b/gamesense/run.py @@ -35,13 +35,13 @@ \b # Run the pipeline with custom config - python run.py --config custom_finetune.yaml + python run.py --config phi3.5_finetune_local.yaml """ ) @click.option( "--config", type=str, - default="default_finetune.yaml", + default="phi3.5_finetune_local.yaml", help="Path to the YAML config file.", ) @click.option( diff --git a/gamesense/steps/__init__.py b/gamesense/steps/__init__.py index b6f0f4e99..a16dc8859 100644 --- a/gamesense/steps/__init__.py +++ b/gamesense/steps/__init__.py @@ -16,7 +16,7 @@ # from .evaluate_model import evaluate_model -from .finetune import finetune, finetune_accelerated +from .finetune import finetune from .log_metadata import log_metadata_from_step_artifact from .prepare_datasets import prepare_data from .promote import promote diff --git a/gamesense/steps/finetune.py b/gamesense/steps/finetune.py index 3d944f6b7..49c317410 100644 --- a/gamesense/steps/finetune.py +++ b/gamesense/steps/finetune.py @@ -196,8 +196,3 @@ def finetune( ) return ft_model_dir - - -finetune_accelerated = run_with_accelerate( - finetune, num_processes=2, multi_gpu=True, mixed_precision="bf16" -) From e95132dbb4d8275e7119a71cc2b293e938012d2f Mon Sep 17 00:00:00 2001 From: Jayesh Sharma Date: Fri, 14 Mar 2025 10:27:41 +0530 Subject: [PATCH 2/2] add client import --- gamesense/steps/finetune.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gamesense/steps/finetune.py b/gamesense/steps/finetune.py index 49c317410..3757801eb 100644 --- a/gamesense/steps/finetune.py +++ b/gamesense/steps/finetune.py @@ -32,6 +32,8 @@ from zenml.logger import get_logger from zenml.materializers import BuiltInMaterializer from zenml.utils.cuda_utils import cleanup_gpu_memory +from zenml.client import Client + logger = get_logger(__name__)