Skip to content

Conversation

@htahir1
Copy link
Contributor

@htahir1 htahir1 commented Oct 15, 2021

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Describe changes

This completely changes the API for step creation with materializers.

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #128 (a9f1ad6) into main (57d04d4) will decrease coverage by 2.16%.
The diff coverage is 39.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   51.80%   49.63%   -2.17%     
==========================================
  Files          65       74       +9     
  Lines        1936     2212     +276     
==========================================
+ Hits         1003     1098      +95     
- Misses        933     1114     +181     
Impacted Files Coverage Δ
src/zenml/cli/config.py 0.00% <0.00%> (ø)
src/zenml/materializers/tf_dataset_materializer.py 0.00% <0.00%> (ø)
...enml/orchestrators/airflow/airflow_orchestrator.py 47.82% <ø> (ø)
src/zenml/stacks/base_stack.py 75.00% <0.00%> (ø)
src/zenml/types/base_type.py 0.00% <0.00%> (ø)
src/zenml/types/pytorch_types.py 0.00% <0.00%> (ø)
src/zenml/materializers/keras_meterializer.py 16.66% <16.66%> (+5.55%) ⬆️
...rc/zenml/orchestrators/local/local_orchestrator.py 50.00% <16.66%> (+2.38%) ⬆️
src/zenml/metadata/base_metadata_store.py 35.48% <16.90%> (-12.80%) ⬇️
src/zenml/materializers/pytorch_materializer.py 21.42% <21.42%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b091b27...a9f1ad6. Read the comment docs.

@schustmi schustmi merged commit cf610fa into main Oct 15, 2021
@schustmi schustmi deleted the hamza/step-design branch October 15, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal To filter out internal PRs and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants