Skip to content

Update contributing and fix ci badge to main #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
htahir1 merged 2 commits into from
Apr 25, 2022
Merged

Update contributing and fix ci badge to main #536

htahir1 merged 2 commits into from
Apr 25, 2022

Conversation

@htahir1
Copy link
Contributor

@htahir1 htahir1 commented Apr 25, 2022

Describe changes

I changed the link of the CI badge to point to main and added the CLA in the contributing.md, as rightly requested by @mbrukman.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added the internal To filter out internal PRs and issues label Apr 25, 2022
@htahir1 htahir1 mentioned this pull request Apr 25, 2022
Closed
8 tasks
AlexejPenner
AlexejPenner approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@AlexejPenner AlexejPenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@htahir1 htahir1 merged commit 786ffe8 into develop Apr 25, 2022
@htahir1 htahir1 deleted the misc/update-contributing-and-fix-ci branch April 25, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@strickvl strickvl strickvl approved these changes

@AlexejPenner AlexejPenner AlexejPenner approved these changes

Assignees

No one assigned

Labels

internal To filter out internal PRs and issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@htahir1 @strickvl @AlexejPenner