Skip to content

Fix linting failures on develop #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
strickvl merged 5 commits into from
May 31, 2022
Merged

Fix linting failures on develop #669

strickvl merged 5 commits into from
May 31, 2022

Conversation

@strickvl
Copy link
Contributor

@strickvl strickvl commented May 31, 2022

I fixed some linting failures which somehow ended up on develop.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@strickvl strickvl added bug Something isn't working internal To filter out internal PRs and issues labels May 31, 2022
@strickvl strickvl requested review from AlexejPenner and schustmi May 31, 2022 10:32
schustmi
schustmi reviewed May 31, 2022
View reviewed changes
@strickvl strickvl requested review from fa9r and safoinme May 31, 2022 10:43
@strickvl
Copy link
Contributor Author

strickvl commented May 31, 2022

@schustmi works now as you suggested. And finally removed the bane of my existence. 🙏🏻

fa9r
fa9r approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@fa9r fa9r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@strickvl strickvl merged commit f73be7b into develop May 31, 2022
@strickvl strickvl deleted the bugfix/linting-failures branch May 31, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schustmi schustmi schustmi left review comments

@safoinme safoinme safoinme approved these changes

@AlexejPenner AlexejPenner AlexejPenner approved these changes

+1 more reviewer

@fa9r fa9r fa9r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working internal To filter out internal PRs and issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@strickvl @schustmi @fa9r @safoinme @AlexejPenner