Skip to content

Conversation

@schustmi
Copy link
Contributor

@schustmi schustmi commented Jun 1, 2022

Describe changes

I used os.path.sep instead of a hardcoded / during class resolving to (hopefully) make it work with windows.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation accordingly.
  • If I have added an integration, I have updated the integrations table.
  • I have added tests to cover my changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues bug Something isn't working labels Jun 1, 2022
@schustmi schustmi requested a review from htahir1 June 1, 2022 15:22
@schustmi schustmi merged commit 13977a6 into develop Jun 1, 2022
@schustmi schustmi deleted the bugfix/windows-class-resolving branch June 1, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working internal To filter out internal PRs and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants