Misc bugfixes #713
Misc bugfixes #713
Conversation
github-actions
bot
added
internal
schustmi
force-pushed
the
bugfix/misc-bugfixes
branch
from
7008d19 to
c45834d
Compare
strickvl
left a comment
strickvl
left a comment
There was a problem hiding this comment.
Just noticed one inconsistency in here (from before you made the PR). Otherwise looks good to me.
| v = getpass.getpass(f"Secret value for {k}:") | ||
| if v: | ||
| secret_contents[k] = v | ||
| secret_contents[k] = expand_argument_value_from_file( |
There was a problem hiding this comment.
When adding the ability to expand secret values from file contents, I was thinking of also doing it in the interactive mode, but then decided not to, because 1. you can't see what you're typing and 2. you don't get auto-completion to help you to point to an existing file on disk. These reasons make it really error prone to specify a path in interactive mode.
There was a problem hiding this comment.
Do you think it's better to remove it again? I've just without checking expected the interactive version to work the same way and tried copy-pasting the paths there with a prepended @ and got confused when it didn't work, that's why I implemented it.
| new_attributes = { | ||
| **component_wrapper.to_component().dict(), | ||
| **parsed_args, | ||
| } |
Describe changes
This PR fixes multiple small things I found when writing the GH actions tutorial:
Pre-requisites
Please ensure you have done the following:
Types of changes